base: Introduce SharedMemoryTracker for POSIX (but not macOS)

base/memory/shared_memory_tracker.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/shared_memory_tracker.h"
+
+#include "base/memory/shared_memory.h"
+#include "base/strings/stringprintf.h"
+#include "base/trace_event/memory_dump_manager.h"
+#include "base/trace_event/process_memory_dump.h"
+
+namespace base {
+
+static base::LazyInstance<SharedMemoryTracker>
+    g_shared_memory_tracker_instance = LAZY_INSTANCE_INITIALIZER;

[Primiano Tucci (use gerrit), 2017/02/27 14:10:50]

1. I think you want this to be a leaky instance as there is no value in clearing
this up in atexit handlers.
2. leaky lazyinstance have been generally dropped in favour of a simple local
static variable, now that in C++11 they are threadsafe.
So here you can just do:

SharedMemoryTracker* SharedMemoryTracker::GetInstance() {
  static SharedMemoryTracker* instance = new SharedMemoryTracker();
  return instance;
}

See for instance FileDescriptorStore::GetInstance()  which uses this pattern

[hajimehoshi, 2017/02/28 06:59:25]

That's good to know. Done.

+
+SharedMemoryTracker* SharedMemoryTracker::GetInstance() {
+  return &g_shared_memory_tracker_instance.Get();
+}
+
+void SharedMemoryTracker::IncrementMemoryUsage(
+    const SharedMemory& shared_memory) {

[Primiano Tucci (use gerrit), 2017/02/27 14:10:50]

I thought I added a comment before, might have gotten lost in the all other
comments.
I think might be useful if the clients here were forced to pass a const char*
(using the same tracing semantic, i.e. we expect that to be a long lived string)
so you could get a name from the thing that requests memory. you could then use
the name in the dump to have better attribution of memory.

[hajimehoshi, 2017/02/28 06:59:25]

Hmm, sounds a good idea, but Increment/DecrementMemoryUsage is now called only
at MapAt/Unmap. Making this accept a name would require change in all callers of
MapAt. If we do that, I think this should be in another CL. What do you think?

+  base::AutoLock hold(lock_);

[Primiano Tucci (use gerrit), 2017/02/27 14:10:50]

you are already in namespace base here, so don't need  "base::" here and
elsewhere in this file

[hajimehoshi, 2017/02/28 06:59:25]

Done.

+  usages_[&shared_memory] = shared_memory.mapped_size();
+}
+
+void SharedMemoryTracker::DecrementMemoryUsage(
+    const SharedMemory& shared_memory) {
+  base::AutoLock hold(lock_);
+  usages_.erase(&shared_memory);
+}
+
+bool SharedMemoryTracker::OnMemoryDump(
+    const base::trace_event::MemoryDumpArgs& args,
+    base::trace_event::ProcessMemoryDump* pmd) {
+  std::unordered_map<SharedMemory::UniqueId, size_t, SharedMemory::UniqueIdHash>
+      sizes;
+  {
+    base::AutoLock hold(lock_);
+    for (const auto& usage : usages_) {
+      SharedMemory::UniqueId id;
+      // TODO(hajimehoshi): There are some cases that the unique id is not
+      // available e.g. when the shared memory handler is handled after
+      // SharedMemory::TakeHandle is called. Fix such problems so that
+      // GetUniqueId to alwasys return id.
+      if (usage.first->GetUniqueId(&id))
+        sizes[id] += usage.second;
+    }
+  }
+  for (auto& size : sizes) {
+    const SharedMemory::UniqueId& id = size.first;
+    std::string dump_name = base::StringPrintf(
+        "%s/%lld.%lld", "shared_memory", static_cast<long long>(id.first),
+        static_cast<long long>(id.second));
+    auto guid = base::trace_event::MemoryAllocatorDumpGuid(dump_name);
+    base::trace_event::MemoryAllocatorDump* local_dump =
+        pmd->CreateAllocatorDump(dump_name);
+    // TODO(hajimehoshi): The size is not resident size but virtual size so far.
+    // Fix this to record resident size.
+    local_dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
+                          base::trace_event::MemoryAllocatorDump::kUnitsBytes,
+                          size.second);
+    base::trace_event::MemoryAllocatorDump* global_dump =
+        pmd->CreateSharedGlobalAllocatorDump(guid);
+    global_dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
+                           base::trace_event::MemoryAllocatorDump::kUnitsBytes,
+                           size.second);
+    // TOOD(hajimehoshi): Detect which the shared memory comes from browser,
+    // renderer or GPU process.
+    // TODO(hajimehoshi): Shared memory reported by GPU and discardable is
+    // currently double-counted. Add ownership edges to avoid this.
+    pmd->AddOwnershipEdge(local_dump->guid(), global_dump->guid());
+  }
+  return true;
+}
+
+SharedMemoryTracker::SharedMemoryTracker() {
+  base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
+      this, "SharedMemoryTracker", nullptr);
+}
+
+SharedMemoryTracker::~SharedMemoryTracker() = default;
+
+}  // namespace