base: Introduce SharedMemoryTracker for POSIX (but not macOS)

base/memory/shared_memory_tracker.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_MEMORY_SHARED_MEMORY_TRACKER_H_
+#define BASE_MEMORY_SHARED_MEMORY_TRACKER_H_
+
+#include "base/atomicops.h"
+#include "base/memory/shared_memory_handle.h"
+#include "base/memory/singleton.h"
+#include "base/trace_event/memory_dump_provider.h"
+
+namespace base {
+
+class SharedMemory;
+
+namespace trace_event {
+class ProcessMemoryDump;
+}
+
+// SharedMemoryTracker tracks shared memory usage.
+class BASE_EXPORT SharedMemoryTracker
+    : public base::trace_event::MemoryDumpProvider {
+ public:
+  // Returns a singleton instance.
+  static SharedMemoryTracker* GetInstance();
+
+  // base::trace_event::MemoryDumpProvider implementation.
+  bool OnMemoryDump(const base::trace_event::MemoryDumpArgs& args,
+                    base::trace_event::ProcessMemoryDump* pmd) override;
+
+  // Records shared memory usage on mapping.
+  bool IncrementMemoryUsage(const SharedMemory& shared_memory);

[Primiano Tucci (use gerrit), 2017/01/27 20:09:49]

why this (and Decrement below) are bool?
- it is not documented what the semantic of the retvalue is
- not sure why the caller should bother by the fact that the tracker suceeds or
not (assuming that is the semantic)
- it seems you just return true below :) can they just be void?

[hajimehoshi, 2017/02/07 12:33:44]

Done.

+
+  // Records shared memory usage on unmapping.
+  bool DecrementMemoryUsage(const SharedMemory& shared_memory);
+
+ private:
+  // TrackerBucket represents a group of shared memory handle ids and their
+  // usages. Shared memorys are split into these buckets instead of using one
+  // big unordered_map so that locking for exclusive control would occur much
+  // less often.
+  struct TrackerBucket {
+    TrackerBucket();
+    ~TrackerBucket();
+    base::Lock lock;
+    std::unordered_map<const SharedMemory*, size_t> usages;
+  };
+
+  friend struct base::DefaultSingletonTraits<SharedMemoryTracker>;
+
+  // TODO(hajimehoshi): Update this number based on actual performance
+  // measurements.
+  static const int kTrackerBucketNum = 1024;
+
+  SharedMemoryTracker();
+  ~SharedMemoryTracker() override;
+
+  TrackerBucket buckets_[kTrackerBucketNum];

[Primiano Tucci (use gerrit), 2017/01/27 20:09:49]

nit: this should go up to line 55. functions  / ctor/dtor should go after
fields.

[hajimehoshi, 2017/02/07 12:33:44]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(SharedMemoryTracker);
+};
+
+}  // namespace base
+
+#endif  // BASE_MEMORY_SHARED_MEMORY_TRACKER_H_