Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2654043003: add warning for deprecated .analysis_options file name (Closed)

Created:
3 years, 11 months ago by danrubel
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add warning for deprecated .analysis_options file name This warns users about using the deprecated analysis options file name and recommend that they rename it. See https://github.com/dart-lang/sdk/issues/28385 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/b43149876058519db4a3142b3c7c4d3538efb870

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M pkg/analyzer/lib/src/analysis_options/error/option_codes.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 11 months ago (2017-01-25 20:13:47 UTC) #2
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-25 20:20:27 UTC) #3
danrubel
3 years, 11 months ago (2017-01-26 03:00:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b43149876058519db4a3142b3c7c4d3538efb870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698