Add gn dependency on v8 back in

Add gn dependency on v8 back in

BUG=none
R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271888

[brettw, 2014-05-06 16:43:58]

lgtm

[jochen (gone - plz use gerrit), 2014-05-06 16:44:36]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-05-06 16:45:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jochen@chromium.org/265403004/1

[jochen (gone - plz use gerrit), 2014-05-07 07:38:57]

Brett, can you help me with this

the build.ninja file generated by gn has an explicit dependency on v8_base.stamp
even though v8_base is an internal target, and nothing depends on it (on
android) - and so it fails to compile (on android)

[jochen (gone - plz use gerrit), 2014-05-07 07:42:58]

The CQ bit was unchecked by jochen@chromium.org

[brettw, 2014-05-07 19:59:09]

I spent a while looking at this. There's a problem making any
executables for Android. For now, can you add this target to the list
of stuff to exclude from the android build at the bottom of the root
BUILD.gn file? I'll look at the problem later this week.

Brett

On Wed, May 7, 2014 at 12:38 AM,  <jochen@chromium.org> wrote:
> Brett, can you help me with this
>
> the build.ninja file generated by gn has an explicit dependency on
> v8_base.stamp
> even though v8_base is an internal target, and nothing depends on it (on
> android) - and so it fails to compile (on android)
>
> https://codereview.chromium.org/265403004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brettw, 2014-05-07 20:00:09]

I also ran into a warning problem compiling for Android. Patch for
v8_base target:

-  configs += [ ":internal_config" ]
+  configs -= [ "//build/config/compiler:chromium_code" ]
+  configs += [ ":internal_config", "//build/config/compiler:no_chromium_code"
]


On Wed, May 7, 2014 at 12:59 PM, Brett Wilson <brettw@chromium.org> wrote:
> I spent a while looking at this. There's a problem making any
> executables for Android. For now, can you add this target to the list
> of stuff to exclude from the android build at the bottom of the root
> BUILD.gn file? I'll look at the problem later this week.
>
> Brett
>
> On Wed, May 7, 2014 at 12:38 AM,  <jochen@chromium.org> wrote:
>> Brett, can you help me with this
>>
>> the build.ninja file generated by gn has an explicit dependency on
>> v8_base.stamp
>> even though v8_base is an internal target, and nothing depends on it (on
>> android) - and so it fails to compile (on android)
>>
>> https://codereview.chromium.org/265403004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2014-05-21 08:31:23]

all done, and rolled, so I'm landing this

[jochen (gone - plz use gerrit), 2014-05-21 08:31:26]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-05-21 08:33:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jochen@chromium.org/265403004/20001

[jochen (gone - plz use gerrit), 2014-05-21 09:31:46]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2014-05-21 13:49:42]

Committed patchset #2 manually as r271888 (presubmit successful).