Add no-info mappings at start of out.js and after mapped functions

Add no-info mappings at start of out.js and after mapped functions

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/6c919f02b4a64476614e21a73e341f1515ef8bbf

[Johnni Winther, 2017-01-25 10:44:19]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-01-25 10:44:20]

https://codereview.chromium.org/2654023003/diff/1/tests/compiler/dart2js/sour...
File tests/compiler/dart2js/sourcemaps/stacktrace_test.dart (right):

https://codereview.chromium.org/2654023003/diff/1/tests/compiler/dart2js/sour...
tests/compiler/dart2js/sourcemaps/stacktrace_test.dart:123:
@{2:test}c.field.method();
Previously the stack trace for this would wrongfully contain mapped frames from
boilerplate code.

[Siggi Cherem (dart-lang), 2017-01-25 16:15:09]

lgtm

https://codereview.chromium.org/2654023003/diff/1/tests/compiler/dart2js/sour...
File tests/compiler/dart2js/sourcemaps/stacktrace_test.dart (right):

https://codereview.chromium.org/2654023003/diff/1/tests/compiler/dart2js/sour...
tests/compiler/dart2js/sourcemaps/stacktrace_test.dart:123:
@{2:test}c.field.method();
On 2017/01/25 10:44:20, Johnni Winther wrote:
> Previously the stack trace for this would wrongfully contain mapped frames
from
> boilerplate code.

What did the frames look like before?

I'm guessing we want to do something about interceptors for the bug in
https://github.com/dart-lang/sdk/issues/28442, but would this change at least
mean that we no longer have an incorrect mapping to trim()?

[Johnni Winther, 2017-01-26 09:59:14]

https://codereview.chromium.org/2654023003/diff/1/tests/compiler/dart2js/sour...
File tests/compiler/dart2js/sourcemaps/stacktrace_test.dart (right):

https://codereview.chromium.org/2654023003/diff/1/tests/compiler/dart2js/sour...
tests/compiler/dart2js/sourcemaps/stacktrace_test.dart:123:
@{2:test}c.field.method();
On 2017/01/25 16:15:09, Siggi Cherem (dart-lang) wrote:
> On 2017/01/25 10:44:20, Johnni Winther wrote:
> > Previously the stack trace for this would wrongfully contain mapped frames
> from
> > boilerplate code.
> 
> What did the frames look like before?
> 
> I'm guessing we want to do something about interceptors for the bug in
> https://github.com/dart-lang/sdk/issues/28442, but would this change at least
> mean that we no longer have an incorrect mapping to trim()?

It had multiple occurrences of the 'test' frame (for instance from
init.currentScript). The test doesn't scrutinize this. I follow up in other CL -
also verifying the status of 28442.

[Johnni Winther, 2017-01-26 10:46:15]

Description was changed from

==========
Add no-info mappings at start of out.js and after mapped functions
==========

to

==========
Add no-info mappings at start of out.js and after mapped functions

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6c919f02b4a64476614e21a73e341f1515ef8bbf
==========

[Johnni Winther, 2017-01-26 10:46:16]

Committed patchset #2 (id:20001) manually as
6c919f02b4a64476614e21a73e341f1515ef8bbf (presubmit successful).