Ensure all code is removed for DCHECK on Windows Official

Ensure all code is removed for DCHECK on Windows Official

See bug for details.

R=danakj@chromium.org
BUG=684105

[scottmg, 2017-01-24 21:06:57]

Description was changed from

==========
Ensure all code is removed foR DCHEck on Windows Official

BUG=684105
==========

to

==========
Ensure all code is removed foR DCHEck on Windows Official

R=danakj@chromium.org
BUG=684105
==========

[scottmg, 2017-01-24 21:06:57]

scottmg@chromium.org changed reviewers:
+ danakj@chromium.org

[scottmg, 2017-01-24 21:08:11]

Description was changed from

==========
Ensure all code is removed foR DCHEck on Windows Official

R=danakj@chromium.org
BUG=684105
==========

to

==========
Ensure all code is removed for DCHECK on Windows Official

See bug for details.

R=danakj@chromium.org
BUG=684105
==========

[scottmg, 2017-01-24 21:10:07]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 21:10:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-01-24 21:10:52]

https://codereview.chromium.org/2653993002/diff/20001/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/2653993002/diff/20001/base/logging.h#newcode731
base/logging.h:731: #if DCHECK_IS_ON()
nested #ifs are such a joy, can u use elif here

https://codereview.chromium.org/2653993002/diff/20001/base/logging.h#newcode762
base/logging.h:762: DCHECK_IS_ON() ?                                            
    \
What about these

[danakj, 2017-01-24 21:11:15]

danakj@chromium.org changed reviewers:
+ dcheng@chromium.org

[danakj, 2017-01-24 21:11:15]

dcheng wrote something similar also and was looking at the OP stuff

[scottmg, 2017-01-24 21:22:22]

On 2017/01/24 21:11:15, danakj (slow) wrote:
> dcheng wrote something similar also and was looking at the OP stuff

OK, closing this one, I'll let Daniel have the distinct honour.