Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/ast/ast-numbering.cc

Issue 2653953006: [ast] Temporarily allow handle dereference for debug printing (Closed)
Patch Set: Change DCHECK since we don't have the isolate Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast-numbering.cc
diff --git a/src/ast/ast-numbering.cc b/src/ast/ast-numbering.cc
index 93dbcc5b06dda2dec4a6ba7fa1261f7d912714ee..fd793f4b80dd679fc4f0c44c3523360d441b2ba1 100644
--- a/src/ast/ast-numbering.cc
+++ b/src/ast/ast-numbering.cc
@@ -649,6 +649,13 @@ bool AstNumberingVisitor::Renumber(FunctionLiteral* node) {
if (FLAG_trace_opt) {
if (disable_crankshaft_reason_ != kNoReason) {
+ // TODO(leszeks): This is a quick'n'dirty fix to allow the debug name of
+ // the function to be accessed in the below print. This DCHECK will fail
+ // if we move ast numbering off the main thread, but that won't be before
+ // we remove FCG, in which case this entire check isn't necessary anyway.
+ AllowHandleDereference allow_deref;
+ DCHECK(!node->debug_name().is_null());
+
PrintF("[enforcing Ignition and TurboFan for %s because: %s\n",
node->debug_name()->ToCString().get(),
GetBailoutReason(disable_crankshaft_reason_));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698