PlzNavigate: transmit redirect info to the renderer side

content/common/navigation_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/optional.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
 #include "content/common/frame_message_enums.h"
 #include "content/common/resource_request_body_impl.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/previews_state.h"
 #include "content/public/common/referrer.h"
 #include "content/public/common/request_context_type.h"
 #include "content/public/common/resource_response.h"
+#include "net/url_request/redirect_info.h"
 #include "third_party/WebKit/public/platform/WebMixedContentContextType.h"
 #include "ui/base/page_transition_types.h"
 #include "url/gurl.h"
 #include "url/origin.h"
 
 namespace content {
 
 // PlzNavigate
 // Helper function to determine if the navigation to |url| should make a request
 // to the network stack. A request should not be sent for JavaScript URLs or
@@ skipping 186 matching lines @@
 };
 
 // Used by FrameMsg_Navigate. Holds the parameters needed by the renderer to
 // start a browser-initiated navigation besides those in CommonNavigationParams.
 // PlzNavigate: sent to the renderer to make it issue a stream request for a
 // navigation that is ready to commit.
 struct CONTENT_EXPORT RequestNavigationParams {
   RequestNavigationParams();
   RequestNavigationParams(bool is_overriding_user_agent,
                           const std::vector<GURL>& redirects,
+                          const GURL& original_url,
+                          const std::string& original_method,
                           bool can_load_local_resources,
                           const PageState& page_state,
                           int nav_entry_id,
                           bool is_history_navigation_in_new_child,
                           std::map<std::string, bool> subframe_unique_names,
                           bool has_committed_real_load,
                           bool intended_as_new_entry,
                           int pending_history_list_offset,
                           int current_history_list_offset,
                           int current_history_list_length,
                           bool is_view_source,
                           bool should_clear_history_list,
                           bool has_user_gesture);
   RequestNavigationParams(const RequestNavigationParams& other);
   ~RequestNavigationParams();
 
   // Whether or not the user agent override string should be used.
   bool is_overriding_user_agent;
 
   // Any redirect URLs that occurred before |url|. Useful for cross-process
   // navigations; defaults to empty.
   std::vector<GURL> redirects;
 
   // The ResourceResponseInfos received during redirects.
   std::vector<ResourceResponseInfo> redirect_response;
 
+  // PlzNavigate
+  // The RedirectInfos received during redirects.
+  std::vector<net::RedirectInfo> redirect_infos;
+
+  // PlzNavigate
+  // The original URL & method for this navigation.
+  GURL original_url;
+  std::string original_method;

[nasko, 2017/02/10 23:53:09]

Can the method change between redirects? If not, why not reuse the one from
CommonNavigationParams?

[clamy, 2017/02/13 14:29:37]

Yes. It's possible for a POST (like a form submission for example) to be
redirected as a GET. See
https://cs.chromium.org/chromium/src/content/browser/frame_host/navigation_re...
(NavigationRequest::OnRequestRedirected) for where we update the method in
CommonNavigationParams.

[nasko, 2017/02/14 17:25:02]

Acknowledged.

+
   // Whether or not this url should be allowed to access local file://
   // resources.
   bool can_load_local_resources;
 
   // Opaque history state (received by ViewHostMsg_UpdateState).
   PageState page_state;
 
   // For browser-initiated navigations, this is the unique id of the
   // NavigationEntry being navigated to. (For renderer-initiated navigations it
   // is 0.) If the load succeeds, then this nav_entry_id will be reflected in
@@ skipping 86 matching lines @@
   ~NavigationParams();
 
   CommonNavigationParams common_params;
   StartNavigationParams start_params;
   RequestNavigationParams request_params;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_NAVIGATION_PARAMS_H_