PlzNavigate: transmit redirect info to the renderer side

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 443 matching lines @@
           entry,                           // entry
           frame_entry,                     // frame_entry
           is_same_document_history_load);  // is_same_document_history_load
 
       dest_render_frame_host->Navigate(
           entry.ConstructCommonNavigationParams(
               frame_entry, post_body, dest_url, dest_referrer, navigation_type,
               previews_state, navigation_start),
           entry.ConstructStartNavigationParams(),
           entry.ConstructRequestNavigationParams(
-              frame_entry, is_history_navigation_in_new_child,
+              frame_entry, GURL(), std::string(),

[nasko, 2017/02/10 23:53:09]

Shouldn't this be dest_url and the actual method?

[clamy, 2017/02/13 14:29:37]

I marked this parameter as PlzNavigate only, hence why I'm not initializing it
in the non-PlzNavigate case. In particular, I was not sure what to put in the
transfer navigation case: should this be the original url, or the url the
transferred renderer needs to navigate to? Since this is not meant to be used
outside of PlzNavigate, I though it was safer not to initialize it.

[nasko, 2017/02/14 17:25:02]

Acknowledged.

+              is_history_navigation_in_new_child,
               entry.GetSubframeUniqueNames(frame_tree_node),
               frame_tree_node->has_committed_real_load(),
               controller_->GetPendingEntryIndex() == -1,
               controller_->GetIndexOfEntry(&entry),
               controller_->GetLastCommittedEntryIndex(),
               controller_->GetEntryCount()));
     } else {
       dest_render_frame_host->navigation_handle()->set_is_transferring(false);
     }
   }
@@ skipping 846 matching lines @@
     if (navigation_handle)
       navigation_handle->update_entry_id_for_transfer(entry->GetUniqueID());
 
     controller_->SetPendingEntry(std::move(entry));
     if (delegate_)
       delegate_->NotifyChangedNavigationState(content::INVALIDATE_TYPE_URL);
   }
 }
 
 }  // namespace content