Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: components/crash/content/app/fallback_crash_handler_win_unittest.cc

Issue 2653953002: Grab crash handler's peak commit charge in fallback handler (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/content/app/fallback_crash_handler_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/fallback_crash_handler_win_unittest.cc
diff --git a/components/crash/content/app/fallback_crash_handler_win_unittest.cc b/components/crash/content/app/fallback_crash_handler_win_unittest.cc
index cdd68d80da8a3af223bd4efea81b12082ef867ab..13ca131f0204c80ae3b82f4d5e95d0649be88b0d 100644
--- a/components/crash/content/app/fallback_crash_handler_win_unittest.cc
+++ b/components/crash/content/app/fallback_crash_handler_win_unittest.cc
@@ -4,6 +4,11 @@
#include "components/crash/content/app/fallback_crash_handler_win.h"
+#include <map>
+#include <memory>
+#include <string>
+#include <vector>
+
#include "base/base_switches.h"
#include "base/command_line.h"
#include "base/files/file_path.h"
@@ -116,7 +121,7 @@ class FallbackCrashHandlerWinTest : public testing::Test {
std::string SelfHandleAsString() const {
return base::UintToString(base::win::HandleToUint32(self_handle_));
- };
+ }
void CreateDatabase() {
std::unique_ptr<crashpad::CrashReportDatabase> database =
@@ -128,6 +133,7 @@ class FallbackCrashHandlerWinTest : public testing::Test {
base::ProcessHandle self_handle_;
base::ScopedTempDir database_dir_;
+ private:
DISALLOW_COPY_AND_ASSIGN(FallbackCrashHandlerWinTest);
};
@@ -239,6 +245,11 @@ TEST_F(FallbackCrashHandlerWinTest, GenerateCrashDump) {
EXPECT_TRUE(base::StringToUint64(it->second, &int_value));
EXPECT_NE(0U, int_value);
+ it = parameters.find("ProcessPeakPagefileUsage");
+ EXPECT_NE(parameters.end(), it);
+ EXPECT_TRUE(base::StringToUint64(it->second, &int_value));
+ EXPECT_NE(0U, int_value);
+
it = parameters.find("SystemCommitRemaining");
EXPECT_NE(parameters.end(), it);
EXPECT_TRUE(base::StringToUint64(it->second, &int_value));
« no previous file with comments | « components/crash/content/app/fallback_crash_handler_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698