third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp - Issue 2653933003: Make stream captures work on canvases that are not in the DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

Issue 2653933003: Make stream captures work on canvases that are not in the DOM. (Closed)

Patch Set: fix test + review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

index 4d23f7d84bff0bedead3c502a3c3e5a1a562c897..b41b009fcceabd957f005f8148a06a89973a8b5e 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp

@@ -813,7 +813,7 @@ TEST_F(CanvasRenderingContext2DTest, NoFallbackWithSmallState) {

context2d()->save();

context2d()->translate(1.0f, 0.0f);

}

- canvasElement().doDeferredPaintInvalidation(); // To close the current frame

+ canvasElement().finalizeFrame(); // To close the current frame

}

TEST_F(CanvasRenderingContext2DTest, FallbackWithLargeState) {

@@ -832,7 +832,7 @@ TEST_F(CanvasRenderingContext2DTest, FallbackWithLargeState) {

context2d()->save();

context2d()->translate(1.0f, 0.0f);

}

- canvasElement().doDeferredPaintInvalidation(); // To close the current frame

+ canvasElement().finalizeFrame(); // To close the current frame

}

TEST_F(CanvasRenderingContext2DTest, OpaqueDisplayListFallsBackForText) {