Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.h

Issue 2653933003: Make stream captures work on canvases that are not in the DOM. (Closed)
Patch Set: fix test + review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
index 70ee8cbf1192033d64be2c193bc720e8f20377f5..212b2427a67017355e0ea00d328acf35dfe702e1 100644
--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
@@ -173,6 +173,8 @@ class CORE_EXPORT HTMLCanvasElement final
// ContextLifecycleObserver and PageVisibilityObserver implementation
void contextDestroyed(ExecutionContext*) override;
+ void finalizeFrame();
+
// PageVisibilityObserver implementation
void pageVisibilityChanged() override;
@@ -194,9 +196,8 @@ class CORE_EXPORT HTMLCanvasElement final
// ImageBufferClient implementation
void notifySurfaceInvalid() override;
- bool isDirty() override { return !m_dirtyRect.isEmpty(); }
+ bool isDirty() { return !m_dirtyRect.isEmpty(); }
xlai (Olivia) 2017/02/08 17:58:40 Since this function no longer override ImageBuffer
Justin Novosad 2017/02/08 18:43:11 Done.
void didDisableAcceleration() override;
- void didFinalizeFrame() override;
void restoreCanvasMatrixClipStack(PaintCanvas*) const override;
void doDeferredPaintInvalidation();

Powered by Google App Engine
This is Rietveld 408576698