Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

Issue 2653933003: Make stream captures work on canvases that are not in the DOM. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
index f67d5eb9cc8286234573eed0edb0cd5bc3849fec..fade2cb9f9b10f19d1236a1a3ca84a38b7dc3d18 100644
--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
@@ -229,7 +229,6 @@ sk_sp<SkPicture> RecordingImageBufferSurface::getPicture() {
FallbackReason fallbackReason = FallbackReasonUnknown;
bool canUsePicture = finalizeFrameInternal(&fallbackReason);
- m_imageBuffer->didFinalizeFrame();
ASSERT(canUsePicture || m_fallbackFactory);
@@ -242,9 +241,9 @@ sk_sp<SkPicture> RecordingImageBufferSurface::getPicture() {
return nullptr;
}
-void RecordingImageBufferSurface::finalizeFrame(const FloatRect& dirtyRect) {
+void RecordingImageBufferSurface::finalizeFrame() {
if (m_fallbackSurface) {
- m_fallbackSurface->finalizeFrame(dirtyRect);
+ m_fallbackSurface->finalizeFrame();
return;
}
@@ -253,6 +252,14 @@ void RecordingImageBufferSurface::finalizeFrame(const FloatRect& dirtyRect) {
fallBackToRasterCanvas(fallbackReason);
}
+void RecordingImageBufferSurface::doPaintInvalidation(
+ const FloatRect& dirtyRect) {
+ if (m_fallbackSurface) {
+ m_fallbackSurface->doPaintInvalidation(dirtyRect);
+ return;
+ }
+}
+
static RecordingImageBufferSurface::FallbackReason flushReasonToFallbackReason(
FlushReason reason) {
switch (reason) {
@@ -299,8 +306,7 @@ bool RecordingImageBufferSurface::finalizeFrameInternal(
ASSERT(m_currentFrame->getRecordingCanvas());
ASSERT(fallbackReason);
ASSERT(*fallbackReason == FallbackReasonUnknown);
-
- if (!m_imageBuffer->isDirty()) {
+ if (!m_didRecordDrawCommandsInCurrentFrame) {
if (!m_previousFrame) {
// Create an initial blank frame
m_previousFrame = m_currentFrame->finishRecordingAsPicture();

Powered by Google App Engine
This is Rietveld 408576698