Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 265393004: Revert 268280 "Pepper: Move manifest logic to components/nacl." (Closed)

Created:
6 years, 7 months ago by miu
Modified:
6 years, 7 months ago
Reviewers:
teravest
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 268280 "Pepper: Move manifest logic to components/nacl." Caused build breakage because static initializer was added to ppb_nacl_private_impl.cc. Candidate (line 96): + const int32_t kPNaClManifestId = std::numeric_limits<int32_t>::max(); > Pepper: Move manifest logic to components/nacl. > > The goal of the trusted plugin refactor is to move as much code as possible out of ppapi/native_client/src/trusted/plugin. This change moves all the manifest parsing and lookup logic out of the trusted plugin at once; it's hard to move piecemeal. > > BUG=353592 > R=bbudge@chromium.org, mallinath@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268250 > > Review URL: https://codereview.chromium.org/264943003 TBR=teravest@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -974 lines) Patch
M trunk/src/components/nacl.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/components/nacl/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/components/nacl/renderer/json_manifest.h View 1 chunk +0 lines, -73 lines 0 comments Download
D trunk/src/components/nacl/renderer/json_manifest.cc View 1 chunk +0 lines, -654 lines 0 comments Download
M trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc View 4 chunks +2 lines, -122 lines 0 comments Download
M trunk/src/ppapi/api/private/ppb_nacl_private.idl View 1 chunk +0 lines, -21 lines 0 comments Download
M trunk/src/ppapi/c/private/ppb_nacl_private.h View 2 chunks +1 line, -17 lines 0 comments Download
A + trunk/src/ppapi/native_client/src/trusted/plugin/json_manifest.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ppapi/native_client/src/trusted/plugin/json_manifest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ppapi/native_client/src/trusted/plugin/manifest.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h View 5 chunks +7 lines, -3 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc View 9 chunks +31 lines, -20 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/plugin.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 5 chunks +62 lines, -6 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_resources.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h View 4 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h View 4 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc View 6 chunks +7 lines, -11 lines 0 comments Download
M trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 2 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
miu
6 years, 7 months ago (2014-05-05 22:19:32 UTC) #1
miu
6 years, 7 months ago (2014-05-05 22:21:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r268295 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698