Move modules-related attributes out from Window.idl.

Move modules-related attributes out from Window.idl.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173414

[Inactive, 2014-05-05 22:19:58]

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
File Source/modules/mediastream/DOMWindowMediaStream.h (right):

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
Source/modules/mediastream/DOMWindowMediaStream.h:15: class DOMWindowMediaStream
FINAL : public NoBaseWillBeGarbageCollectedFinalized<DOMWindowMediaStream>,
public WillBeHeapSupplement<DOMWindow>, public DOMWindowProperty {
This is a class corresponding to a partial interface. Those should not need to
subclass anything.

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
Source/modules/mediastream/DOMWindowMediaStream.h:17: public:
Where are the static functions corresponding to the IDL operations? How does
this build?

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
Source/modules/mediastream/DOMWindowMediaStream.h:21: DOMWindow& m_window;
Should not be needed.

[Inactive, 2014-05-05 22:20:41]

On 2014/05/05 22:19:58, Chris Dumez wrote:
>
https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
> File Source/modules/mediastream/DOMWindowMediaStream.h (right):
> 
>
https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
> Source/modules/mediastream/DOMWindowMediaStream.h:15: class
DOMWindowMediaStream
> FINAL : public NoBaseWillBeGarbageCollectedFinalized<DOMWindowMediaStream>,
> public WillBeHeapSupplement<DOMWindow>, public DOMWindowProperty {
> This is a class corresponding to a partial interface. Those should not need to
> subclass anything.
> 
>
https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
> Source/modules/mediastream/DOMWindowMediaStream.h:17: public:
> Where are the static functions corresponding to the IDL operations? How does
> this build?
> 
>
https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
> Source/modules/mediastream/DOMWindowMediaStream.h:21: DOMWindow& m_window;
> Should not be needed.

Same comments apply to other "proxy" classes for partial interfaces in your CL.

[Inactive, 2014-05-06 14:42:42]

FYI, the mac try bot issues look legit.

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
File Source/modules/mediastream/DOMWindowMediaStream.h (right):

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
Source/modules/mediastream/DOMWindowMediaStream.h:15: class DOMWindowMediaStream
FINAL : public NoBaseWillBeGarbageCollectedFinalized<DOMWindowMediaStream>,
public WillBeHeapSupplement<DOMWindow>, public DOMWindowProperty {
On 2014/05/05 22:19:58, Chris Dumez wrote:
> This is a class corresponding to a partial interface. Those should not need to
> subclass anything.

I missed that your partial interface only contains "Constructor" attributes. In
this case, you shouldn't need this class at all. Hopefully, you shouldn't even
need this header but the bindings generator might need some tweaking.

[c.shu, 2014-05-06 15:01:11]

Thanks for the review. I have removed the unnecessary changes in the 2nd patch.

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
File Source/modules/mediastream/DOMWindowMediaStream.h (right):

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
Source/modules/mediastream/DOMWindowMediaStream.h:15: class DOMWindowMediaStream
FINAL : public NoBaseWillBeGarbageCollectedFinalized<DOMWindowMediaStream>,
public WillBeHeapSupplement<DOMWindow>, public DOMWindowProperty {
On 2014/05/06 14:42:43, Chris Dumez wrote:
> On 2014/05/05 22:19:58, Chris Dumez wrote:
> > This is a class corresponding to a partial interface. Those should not need
to
> > subclass anything.
> 
> I missed that your partial interface only contains "Constructor" attributes.
In
> this case, you shouldn't need this class at all. Hopefully, you shouldn't even
> need this header but the bindings generator might need some tweaking.

Done.

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
Source/modules/mediastream/DOMWindowMediaStream.h:17: public:
On 2014/05/05 22:19:58, Chris Dumez wrote:
> Where are the static functions corresponding to the IDL operations? How does
> this build?

Done.

https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/D...
Source/modules/mediastream/DOMWindowMediaStream.h:21: DOMWindow& m_window;
On 2014/05/05 22:19:58, Chris Dumez wrote:
> Should not be needed.

Done.

[abarth-chromium, 2014-05-06 18:21:38]

lgtm

[commit-bot: I haz the power, 2014-05-06 18:21:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/c.shu@samsung.com/265393003/20001

[commit-bot: I haz the power, 2014-05-06 18:51:06]

Change committed as 173414