Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 265393003: Move modules-related attributes out from Window.idl. (Closed)

Created:
6 years, 7 months ago by c.shu
Modified:
6 years, 7 months ago
CC:
blink-reviews, arv+blink, alecflett, ericu+idb_chromium.org, Raymond Toy, tommyw+watchlist_chromium.org, dgrogan, cmumford, jsbell+idb_chromium.org, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move modules-related attributes out from Window.idl. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173414

Patch Set 1 #

Total comments: 7

Patch Set 2 : Remove unnecessary code changes in the previous patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -25 lines) Patch
M Source/core/core.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +0 lines, -23 lines 0 comments Download
M Source/modules/indexeddb/WindowIndexedDatabase.idl View 1 chunk +9 lines, -0 lines 0 comments Download
A Source/modules/mediastream/DOMWindowMediaStream.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
A Source/modules/mediastream/WindowMediaStream.idl View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/modules/modules.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download
A Source/modules/speech/DOMWindowSpeech.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
A Source/modules/speech/WindowSpeech.idl View 1 chunk +14 lines, -0 lines 0 comments Download
A Source/modules/webaudio/DOMWindowWebAudio.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
A Source/modules/webaudio/WindowWebAudio.idl View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
c.shu
6 years, 7 months ago (2014-05-05 22:07:23 UTC) #1
Inactive
https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/DOMWindowMediaStream.h File Source/modules/mediastream/DOMWindowMediaStream.h (right): https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/DOMWindowMediaStream.h#newcode15 Source/modules/mediastream/DOMWindowMediaStream.h:15: class DOMWindowMediaStream FINAL : public NoBaseWillBeGarbageCollectedFinalized<DOMWindowMediaStream>, public WillBeHeapSupplement<DOMWindow>, public ...
6 years, 7 months ago (2014-05-05 22:19:58 UTC) #2
Inactive
On 2014/05/05 22:19:58, Chris Dumez wrote: > https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/DOMWindowMediaStream.h > File Source/modules/mediastream/DOMWindowMediaStream.h (right): > > https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/DOMWindowMediaStream.h#newcode15 ...
6 years, 7 months ago (2014-05-05 22:20:41 UTC) #3
Inactive
FYI, the mac try bot issues look legit. https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/DOMWindowMediaStream.h File Source/modules/mediastream/DOMWindowMediaStream.h (right): https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/DOMWindowMediaStream.h#newcode15 Source/modules/mediastream/DOMWindowMediaStream.h:15: class ...
6 years, 7 months ago (2014-05-06 14:42:42 UTC) #4
c.shu
Thanks for the review. I have removed the unnecessary changes in the 2nd patch. https://codereview.chromium.org/265393003/diff/1/Source/modules/mediastream/DOMWindowMediaStream.h ...
6 years, 7 months ago (2014-05-06 15:01:11 UTC) #5
abarth-chromium
lgtm
6 years, 7 months ago (2014-05-06 18:21:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/265393003/20001
6 years, 7 months ago (2014-05-06 18:21:59 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 18:51:06 UTC) #8
Message was sent while issue was closed.
Change committed as 173414

Powered by Google App Engine
This is Rietveld 408576698