Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

Issue 2653923008: Reland of Split PendingScript into PendingScript and ClassicPendingScript (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
index c5749fa4a81ab6850b081e763688b20e5b5d0577..8cc19d3cee6f102af65dd8c47227a515198b6d1b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
@@ -11,9 +11,8 @@
#include "bindings/core/v8/V8BindingForCore.h"
#include "bindings/core/v8/V8BindingForTesting.h"
#include "bindings/core/v8/V8ScriptRunner.h"
+#include "core/dom/ClassicPendingScript.h"
#include "core/dom/ClassicScript.h"
-#include "core/dom/Element.h"
-#include "core/dom/PendingScript.h"
#include "core/frame/Settings.h"
#include "platform/heap/Handle.h"
#include "platform/testing/UnitTestHelpers.h"
@@ -36,9 +35,10 @@ class ScriptStreamingTest : public ::testing::Test {
settings_(Settings::Create()),
resource_request_("http://www.streaming-test.com/"),
resource_(ScriptResource::Create(resource_request_, "UTF-8")),
- pending_script_(PendingScript::CreateForTesting(resource_.Get())) {
+ pending_script_(
+ ClassicPendingScript::CreateForTesting(resource_.Get())) {
resource_->SetStatus(ResourceStatus::kPending);
- pending_script_ = PendingScript::CreateForTesting(resource_.Get());
+ pending_script_ = ClassicPendingScript::CreateForTesting(resource_.Get());
ScriptStreamer::SetSmallScriptThresholdForTesting(0);
}
@@ -47,7 +47,9 @@ class ScriptStreamingTest : public ::testing::Test {
pending_script_->Dispose();
}
- PendingScript* GetPendingScript() const { return pending_script_.Get(); }
+ ClassicPendingScript* GetPendingScript() const {
+ return pending_script_.Get();
+ }
protected:
void AppendData(const char* data) {
@@ -90,7 +92,7 @@ class ScriptStreamingTest : public ::testing::Test {
// ScriptResource::appendData.
ResourceRequest resource_request_;
Persistent<ScriptResource> resource_;
- Persistent<PendingScript> pending_script_;
+ Persistent<ClassicPendingScript> pending_script_;
};
class TestPendingScriptClient

Powered by Google App Engine
This is Rietveld 408576698