Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerImpl.h

Issue 2653923008: Reland of Split PendingScript into PendingScript and ClassicPendingScript (Closed)
Patch Set: Crash fix by adding Dispose() as ClassicPendingScript prefinalizer Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerImpl.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerImpl.h b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerImpl.h
index 5a4c94401eb8c3f46e60bf7fc4d61e26e42d06a0..972ad947ce6aa98a05205dbb69a3c1055246177b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerImpl.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerImpl.h
@@ -9,6 +9,7 @@
#include "bindings/core/v8/ScriptStreamer.h"
#include "core/CoreExport.h"
+#include "platform/WebTaskRunner.h"
#include "platform/heap/Handle.h"
#include "platform/wtf/Noncopyable.h"
#include "platform/wtf/text/WTFString.h"
@@ -16,13 +17,12 @@
namespace blink {
-class PendingScript;
+class ClassicPendingScript;
class Resource;
class ScriptResource;
class ScriptState;
class Settings;
class SourceStream;
-class WebTaskRunner;
class CORE_EXPORT ScriptStreamerImpl final : public ScriptStreamer {
WTF_MAKE_NONCOPYABLE(ScriptStreamerImpl);
@@ -32,8 +32,8 @@ class CORE_EXPORT ScriptStreamerImpl final : public ScriptStreamer {
DECLARE_TRACE();
// Launches a task (on a background thread) which will stream the given
- // PendingScript into V8 as it loads.
- static void StartStreaming(PendingScript*,
+ // ClassicPendingScript into V8 as it loads.
+ static void StartStreaming(ClassicPendingScript*,
Type,
Settings*,
ScriptState*,
@@ -69,7 +69,7 @@ class CORE_EXPORT ScriptStreamerImpl final : public ScriptStreamer {
static size_t small_script_threshold_;
static ScriptStreamerImpl* Create(
- PendingScript* script,
+ ClassicPendingScript* script,
Type script_type,
ScriptState* script_state,
v8::ScriptCompiler::CompileOptions compile_options,
@@ -78,7 +78,7 @@ class CORE_EXPORT ScriptStreamerImpl final : public ScriptStreamer {
compile_options,
std::move(loading_task_runner));
}
- ScriptStreamerImpl(PendingScript*,
+ ScriptStreamerImpl(ClassicPendingScript*,
Type,
ScriptState*,
v8::ScriptCompiler::CompileOptions,
@@ -93,16 +93,16 @@ class CORE_EXPORT ScriptStreamerImpl final : public ScriptStreamer {
void NotifyFinished(Resource*) override;
void Cancel() override;
- static bool StartStreamingInternal(PendingScript*,
+ static bool StartStreamingInternal(ClassicPendingScript*,
Type,
Settings*,
ScriptState*,
RefPtr<WebTaskRunner>);
- Member<PendingScript> pending_script_;
- // This pointer is weak. If PendingScript and its Resource are deleted
- // before ScriptStreamer, PendingScript will notify ScriptStreamer of its
- // deletion by calling cancel().
+ Member<ClassicPendingScript> pending_script_;
+ // This pointer is weak. If ClassicPendingScript and its Resource are deleted
+ // before ScriptStreamer, ClassicPendingScript will notify ScriptStreamer of
+ // its deletion by calling cancel().
Member<ScriptResource> resource_;
// Whether ScriptStreamer is detached from the Resource. In those cases, the
// script data is not needed any more, and the client won't get notified

Powered by Google App Engine
This is Rietveld 408576698