Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

Issue 2653923008: Reland of Split PendingScript into PendingScript and ClassicPendingScript (Closed)
Patch Set: Fix file header Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
index b0bfdb0ba01865b2df0fed3e900d73cac349b874..ab19bcbcb3f70429483efca6fd3a00791d9db74e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
@@ -7,9 +7,9 @@
#include <memory>
#include "bindings/core/v8/ScriptStreamerThread.h"
#include "bindings/core/v8/V8ScriptRunner.h"
+#include "core/dom/ClassicPendingScript.h"
#include "core/dom/Document.h"
#include "core/dom/Element.h"
-#include "core/dom/PendingScript.h"
#include "core/frame/Settings.h"
#include "core/html/parser/TextResourceDecoder.h"
#include "core/loader/resource/ScriptResource.h"
@@ -322,7 +322,7 @@ class SourceStream : public v8::ScriptCompiler::ExternalSourceStream {
size_t ScriptStreamer::s_smallScriptThreshold = 30 * 1024;
-void ScriptStreamer::startStreaming(PendingScript* script,
+void ScriptStreamer::startStreaming(ClassicPendingScript* script,
Type scriptType,
Settings* settings,
ScriptState* scriptState,
@@ -511,7 +511,7 @@ void ScriptStreamer::notifyFinished(Resource* resource) {
}
ScriptStreamer::ScriptStreamer(
- PendingScript* script,
+ ClassicPendingScript* script,
Type scriptType,
ScriptState* scriptState,
v8::ScriptCompiler::CompileOptions compileOptions,
@@ -575,7 +575,7 @@ void ScriptStreamer::notifyFinishedToClient() {
}
bool ScriptStreamer::startStreamingInternal(
- PendingScript* script,
+ ClassicPendingScript* script,
Type scriptType,
Settings* settings,
ScriptState* scriptState,
@@ -594,7 +594,7 @@ bool ScriptStreamer::startStreamingInternal(
if (resource->isCacheValidator()) {
recordNotStreamingReasonHistogram(scriptType, Reload);
// This happens e.g., during reloads. We're actually not going to load
- // the current Resource of the PendingScript but switch to another
+ // the current Resource of the ClassicPendingScript but switch to another
// Resource -> don't stream.
return false;
}
@@ -610,8 +610,8 @@ bool ScriptStreamer::startStreamingInternal(
compileOption = v8::ScriptCompiler::kProduceParserCache;
// The Resource might go out of scope if the script is no longer
- // needed. This makes PendingScript notify the ScriptStreamer when it is
- // destroyed.
+ // needed. This makes ClassicPendingScript notify the ScriptStreamer when it
+ // is destroyed.
script->setStreamer(ScriptStreamer::create(script, scriptType, scriptState,
compileOption,
std::move(loadingTaskRunner)));

Powered by Google App Engine
This is Rietveld 408576698