Check username validity in the FakeAuthPolicyClient

chromeos/dbus/fake_auth_policy_client.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/fake_auth_policy_client.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/location.h"
 #include "base/md5.h"
 #include "base/path_service.h"
+#include "base/strings/string_split.h"
 #include "base/task_scheduler/post_task.h"
 #include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h"
 #include "chromeos/chromeos_paths.h"
 #include "chromeos/cryptohome/cryptohome_parameters.h"
 #include "chromeos/dbus/cryptohome_client.h"
 #include "components/policy/proto/cloud_policy.pb.h"
 #include "components/policy/proto/device_management_backend.pb.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace em = enterprise_management;
 
 namespace {
 
+const size_t kMaxMachineNameLength = 15;
+const char kInvalidMachineNameCharacters[] = "\\/:*?\"<>|";
+
 // Drop stub policy file of |policy_type| at |policy_path| containing
 // |serialized_payload|.
 bool WritePolicyFile(const base::FilePath& policy_path,
                      const std::string& serialized_payload,
                      const std::string& policy_type) {
   em::PolicyData data;
   data.set_policy_value(serialized_payload);
   data.set_policy_type(policy_type);
 
   em::PolicyFetchResponse response;
@@ skipping 21 matching lines @@
 FakeAuthPolicyClient::FakeAuthPolicyClient() {}
 
 FakeAuthPolicyClient::~FakeAuthPolicyClient() {}
 
 void FakeAuthPolicyClient::Init(dbus::Bus* bus) {}
 
 void FakeAuthPolicyClient::JoinAdDomain(const std::string& machine_name,
                                         const std::string& user_principal_name,
                                         int password_fd,
                                         const JoinCallback& callback) {
+  if (machine_name.size() > kMaxMachineNameLength) {
+    callback.Run(authpolicy::ERROR_MACHINE_NAME_TOO_LONG);
+    return;
+  }
+
+  if (machine_name.empty() ||
+      machine_name.find_first_of(kInvalidMachineNameCharacters) !=
+          std::string::npos) {
+    callback.Run(authpolicy::ERROR_BAD_MACHINE_NAME);
+    return;
+  }
+
+  std::vector<std::string> parts = base::SplitString(
+      user_principal_name, "@", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+  if (parts.size() != 2 || parts[0].empty() || parts[1].empty()) {
+    callback.Run(authpolicy::ERROR_PARSE_UPN_FAILED);
+    return;
+  }
+
   callback.Run(authpolicy::ERROR_NONE);
 }
 
 void FakeAuthPolicyClient::AuthenticateUser(
     const std::string& user_principal_name,
     int password_fd,
     const AuthCallback& callback) {
   callback.Run(authpolicy::ERROR_NONE, base::MD5String(user_principal_name));
 }
 
@@ skipping 46 matching lines @@
                      .WithShutdownBehavior(
                          base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN)
                      .WithPriority(base::TaskPriority::BACKGROUND)
                      .MayBlock(),
       base::Bind(&WritePolicyFile, policy_path, payload,
                  "google/chromeos/user"),
       callback);
 }
 
 }  // namespace chromeos