Check username validity in the FakeAuthPolicyClient

chromeos/dbus/fake_auth_policy_client_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/dbus/fake_auth_policy_client.h"
+
+#include "base/bind.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromeos {
+namespace {
+
+const char kMachineName[] = "machine_name";

[achuithb, 2017/01/25 20:02:46]

I think this just adds noise - why not pass in ""

[Roman Sorokin (ftl), 2017/01/26 13:10:14]

I decided to add machine_name checks, and tests for them.

+
+void JoinAdCallback(authpolicy::ErrorType expected,
+                    authpolicy::ErrorType actual) {
+  EXPECT_EQ(expected, actual);

[achuithb, 2017/01/25 20:02:46]

Hmm, I believe you won't be able to tell which case failed when this fails. Does
it make sense to also pass in the user_principal_name into this function and
print it?

In general we avoid calling EXPECT in helper functions for this reason.

[Roman Sorokin (ftl), 2017/01/26 13:10:14]

Done.

+}
+
+}  // namespace
+
+TEST(FakeAuthPolicyClientTest, JoinAdDomain_ParseUPN) {
+  FakeAuthPolicyClient client;
+  client.JoinAdDomain(kMachineName, "user@realm.com", /* password_fd */ -1,
+                      base::Bind(&JoinAdCallback, authpolicy::ERROR_NONE));
+
+  client.JoinAdDomain(
+      kMachineName, "user", /* password_fd */ -1,
+      base::Bind(&JoinAdCallback, authpolicy::ERROR_PARSE_UPN_FAILED));
+
+  client.JoinAdDomain(
+      kMachineName, "", /* password_fd */ -1,
+      base::Bind(&JoinAdCallback, authpolicy::ERROR_PARSE_UPN_FAILED));
+
+  client.JoinAdDomain(
+      kMachineName, "user@", /* password_fd */ -1,
+      base::Bind(&JoinAdCallback, authpolicy::ERROR_PARSE_UPN_FAILED));
+
+  client.JoinAdDomain(
+      kMachineName, "@realm.com", /* password_fd */ -1,
+      base::Bind(&JoinAdCallback, authpolicy::ERROR_PARSE_UPN_FAILED));
+
+  client.JoinAdDomain(
+      kMachineName, "user@realm@com", /* password_fd */ -1,
+      base::Bind(&JoinAdCallback, authpolicy::ERROR_PARSE_UPN_FAILED));
+}
+
+}  // namespace chromeos