fix #28141, fix super generic method bounds check

fix #28141, fix super generic method bounds check

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/25b6e461542ff76d8e750b4d1b26c413d4b79f3f

[Jennifer Messerly, 2017-01-24 03:09:15]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2017-01-24 03:09:16]

https://codereview.chromium.org/2653873002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2653873002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:6158: void
_checkTypeArguments(InvocationExpression node) {
rewrote this to simplify

in general -- when we stick to the world of types (vs elements) we're going to
have a better time tracking type parameters.

[Leaf, 2017-01-24 19:10:05]

lgtm

https://codereview.chromium.org/2653873002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/member.dart (right):

https://codereview.chromium.org/2653873002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/member.dart:976: newTypeFormal._bound =
bound.substitute2(
Consider doing this in a separate loop afterwards to avoid relying on a left to
right ordering of the parameter dependencies. e.g.

var newTypeVariables = ....getTypes(result);
result.forEach((f) = f._bound = bound.substitute2(newTypeVariables,
formalTypes);
return result;

[Jennifer Messerly, 2017-01-24 22:44:00]

thank you! took that suggestion

https://codereview.chromium.org/2653873002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/member.dart (right):

https://codereview.chromium.org/2653873002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/member.dart:976: newTypeFormal._bound =
bound.substitute2(
On 2017/01/24 19:10:05, Leaf wrote:
> Consider doing this in a separate loop afterwards to avoid relying on a left
to
> right ordering of the parameter dependencies. e.g.
> 
> var newTypeVariables = ....getTypes(result);
> result.forEach((f) = f._bound = bound.substitute2(newTypeVariables,
> formalTypes);
> return result;

excellent idea

[Jennifer Messerly, 2017-01-24 22:44:54]

Description was changed from

==========
fix #28141, fix super generic method bounds check

BUG=
==========

to

==========
fix #28141, fix super generic method bounds check
==========

[Jennifer Messerly, 2017-01-24 22:51:44]

Description was changed from

==========
fix #28141, fix super generic method bounds check
==========

to

==========
fix #28141, fix super generic method bounds check

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/25b6e461542ff76d8e750b4d1b26c413d4b79f3f
==========

[Jennifer Messerly, 2017-01-24 22:51:45]

Committed patchset #2 (id:20001) manually as
25b6e461542ff76d8e750b4d1b26c413d4b79f3f (presubmit successful).