Issue 2653863003: Clean up new errors and warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2653863003: Clean up new errors and warnings (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson

Modified:
3 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Clean up new errors and warnings R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/dd3b191addee5e018efcc467bbf2217d04e796ca

Patch Set 1 #

Total comments: 1

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -36 lines)			Patch
	M	pkg/analyzer/lib/src/generated/error_verifier.dart	View		2 chunks	+33 lines, -34 lines	1 comment	Download
	M	pkg/analyzer/lib/src/generated/utilities_collection.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

https://codereview.chromium.org/2653863003/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart File pkg/analyzer/lib/src/generated/error_verifier.dart (left): https://codereview.chromium.org/2653863003/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart#oldcode2952 pkg/analyzer/lib/src/generated/error_verifier.dart:2952: ImplementsClause implementsClause = node.implementsClause; This file was sorted, so ...

3 years, 10 months ago (2017-01-24 22:28:53 UTC) #2

Brian Wilkerson

3 years, 10 months ago (2017-01-24 22:32:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dd3b191addee5e018efcc467bbf2217d04e796ca (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages