Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2263)

Unified Diff: chrome/common/extensions/docs/server2/template_data_source_test.py

Issue 26538009: Docserver: make file_system a property of Create (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: niggles Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/template_data_source_test.py
diff --git a/chrome/common/extensions/docs/server2/template_data_source_test.py b/chrome/common/extensions/docs/server2/template_data_source_test.py
index 9e743a55d578411fabad8c474183b228fbf3e624..26de53f02a7a25a90bd3cccd78f8c0f69988898b 100755
--- a/chrome/common/extensions/docs/server2/template_data_source_test.py
+++ b/chrome/common/extensions/docs/server2/template_data_source_test.py
@@ -66,9 +66,11 @@ class TemplateDataSourceTest(unittest.TestCase):
data_source.Render(template_name))
def _CreateTemplateDataSource(self, compiled_fs_factory, api_data=None):
+ file_system = LocalFileSystem(self._base_path)
if api_data is None:
api_data_factory = APIDataSource.Factory(
compiled_fs_factory,
+ file_system,
'fake_path',
_FakeFactory(),
TestBranchUtility.CreateWithCannedData())
@@ -88,6 +90,7 @@ class TemplateDataSourceTest(unittest.TestCase):
self._fake_intro_data_source_factory,
self._fake_samples_data_source_factory,
compiled_fs_factory,
+ file_system,
reference_resolver_factory,
'.',
'.',
@@ -95,9 +98,7 @@ class TemplateDataSourceTest(unittest.TestCase):
def testSimple(self):
self._base_path = os.path.join(self._base_path, 'simple')
- fetcher = LocalFileSystem(self._base_path)
compiled_fs_factory = CompiledFileSystem.Factory(
- fetcher,
ObjectStoreCreator.ForTest())
t_data_source = self._CreateTemplateDataSource(
compiled_fs_factory,
@@ -113,9 +114,7 @@ class TemplateDataSourceTest(unittest.TestCase):
@DisableLogging('warning')
def testNotFound(self):
self._base_path = os.path.join(self._base_path, 'simple')
- fetcher = LocalFileSystem(self._base_path)
compiled_fs_factory = CompiledFileSystem.Factory(
- fetcher,
ObjectStoreCreator.ForTest())
t_data_source = self._CreateTemplateDataSource(
compiled_fs_factory,
@@ -124,9 +123,7 @@ class TemplateDataSourceTest(unittest.TestCase):
def testPartials(self):
self._base_path = os.path.join(self._base_path, 'partials')
- fetcher = LocalFileSystem(self._base_path)
compiled_fs_factory = CompiledFileSystem.Factory(
- fetcher,
ObjectStoreCreator.ForTest())
t_data_source = self._CreateTemplateDataSource(compiled_fs_factory)
self.assertEqual(
@@ -136,10 +133,8 @@ class TemplateDataSourceTest(unittest.TestCase):
def testRender(self):
self._base_path = os.path.join(self._base_path, 'render')
- fetcher = LocalFileSystem(self._base_path)
context = json.loads(self._ReadLocalFile('test1.json'))
compiled_fs_factory = CompiledFileSystem.Factory(
- fetcher,
ObjectStoreCreator.ForTest())
self._RenderTest(
'test1',

Powered by Google App Engine
This is Rietveld 408576698