Docserver: make file_system a property of Create

chrome/common/extensions/docs/server2/host_file_system_provider.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from caching_file_system import CachingFileSystem
 from local_file_system import LocalFileSystem
 from offline_file_system import OfflineFileSystem
 from subversion_file_system import SubversionFileSystem
 from third_party.json_schema_compiler.memoize import memoize
 
@@ skipping 74 matching lines @@
     if self._constructor_for_test is not None:
       file_system = self._constructor_for_test(branch=branch, revision=revision)
     else:
       file_system = SubversionFileSystem.Create(branch=branch,
                                                 revision=revision)
     if self._offline:
       file_system = OfflineFileSystem(file_system)
     return CachingFileSystem(file_system, self._object_store_creator)
 
   @staticmethod
-  def ForLocal(object_store_creator):
+  def ForLocal(object_store_creator, **optargs):
     '''Used in creating a server instance on localhost.
     '''
-    return HostFileSystemProvider(
-        object_store_creator,
-        constructor_for_test=lambda **_: LocalFileSystem.Create())
+    optargs['constructor_for_test'] = lambda **_: LocalFileSystem.Create()

[Jeffrey Yasskin, 2013/10/14 18:52:31]

You can write:

HostFileSystemProvider(
  object_store_creator,
  constructor_for_test=lambda **_: LocalFileSystem.Create(),
  **optargs)

That'll throw an exception if the user passes 'constructor_for_test' into
ForLocal, while yours will silently override their argument, but I suspect that
difference doesn't matter.

[not at google - send to devlin, 2013/10/14 21:03:34]

Done.

+    return HostFileSystemProvider(object_store_creator, **optargs)
 
   @staticmethod
-  def ForTest(file_system, object_store_creator):
+  def ForTest(file_system, object_store_creator, **optargs):
     '''Used in creating a test server instance. The HostFileSystemProvider
     returned here will always return |file_system| when its Create() method is
     called.
     '''
-    return HostFileSystemProvider(
-        object_store_creator,
-        constructor_for_test=lambda **_: file_system)
+    optargs['constructor_for_test'] = lambda **_: file_system
+    return HostFileSystemProvider(object_store_creator, **optargs)