[devtools] Remove trailing fragment identifier from script urls

Source/core/fetch/ScriptResource.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 66 matching lines @@
         // We lie a it here and claim that script counts as encoded data (even though it's really decoded data).
         // That's because the MemoryCache thinks that it can clear out decoded data by calling destroyDecodedData(),
         // but we can't destroy script in destroyDecodedData because that's our only copy of the data!
         setEncodedSize(script.sizeInBytes());
         m_script = script;
     }
 
     return m_script.string();
 }
 
+const KURL& ScriptResource::scriptURL()
+{
+    if (!response().url().isEmpty() && m_url.isEmpty()) {
+        m_url = response().url();
+        m_url.removeFragmentIdentifier();
+    }
+    return m_url;

[abarth-chromium, 2013/10/17 01:06:55]

Why do we need to store this data?  Is it really too expensive to recompute it
each time?

[johnjbarton, 2013/10/17 02:30:11]

I believe we need to store this data so the const KURL& has something to point
to.
No, the only time we need to store is if we call scriptURL (already true) and if
we have a fragment id. So I could check the response().url() for a fragment,
update in that case, else return the response().url(). That way the
ScriptResource.m_url is an empty KURL except in the case we are using # URLs.

[abarth-chromium, 2013/10/17 02:39:05]

We can return a KURL rather than a const KURL&

+}
+
 bool ScriptResource::mimeTypeAllowedByNosniff() const
 {
     return parseContentTypeOptionsHeader(m_response.httpHeaderField("X-Content-Type-Options")) != ContentTypeOptionsNosniff || MIMETypeRegistry::isSupportedJavaScriptMIMEType(mimeType());
 }
 
 } // namespace WebCore