[devtools] Remove trailing fragment identifier from script urls

Source/bindings/v8/ScriptSourceCode.h

 /*
  * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 32 matching lines @@
 namespace WebCore {
 
 class ScriptSourceCode {
 public:
     ScriptSourceCode(const String& source, const KURL& url = KURL(), const TextPosition& startPosition = TextPosition::minimumPosition())
         : m_source(source)
         , m_resource(0)
         , m_url(url)
         , m_startPosition(startPosition)
     {
+        if (!m_url.isEmpty())
+            m_url.removeFragmentIdentifier();

[abarth-chromium, 2013/10/17 01:06:55]

Ah, much better.

     }
 
     // We lose the encoding information from ScriptResource.
     // Not sure if that matters.
     ScriptSourceCode(ScriptResource* cs)
         : m_source(cs->script())
         , m_resource(cs)
         , m_url(cs->url())
         , m_startPosition(TextPosition::minimumPosition())
     {
+        if (!m_url.isEmpty())
+            m_url.removeFragmentIdentifier();
     }
 
     bool isEmpty() const { return m_source.isEmpty(); }
 
     const String& source() const { return m_source; }
     ScriptResource* resource() const { return m_resource.get(); }
     const KURL& url() const
     {
         if (m_resource)
-            return m_resource->response().url();
+            return m_resource->scriptURL();
         return m_url;

[abarth-chromium, 2013/10/17 01:06:55]

Why not store the data in m_url instead of in ScriptResource?  We already have
storage for it here.  There's no reason to bloat the memory cache with yet
another KURL member.

[johnjbarton, 2013/10/17 02:30:11]

Maybe my C++ is rusty, but the method here is const so we can't mutate the m_url
to update it with m_resource scriptURL()

[abarth-chromium, 2013/10/17 02:39:05]

You can mark the m_url member as |mutable|.

     }
     int startLine() const { return m_startPosition.m_line.oneBasedInt(); }
     const TextPosition& startPosition() const { return m_startPosition; }
 
 private:
     String m_source;
     ResourcePtr<ScriptResource> m_resource;
     KURL m_url;
     TextPosition m_startPosition;
 };
 
 } // namespace WebCore
 
 #endif // ScriptSourceCode_h