Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2653773004: [LayoutNG] Add LayoutObject pointer to each NGPhysicalFragment. (Closed)

Created:
3 years, 11 months ago by ikilpatrick
Modified:
3 years, 10 months ago
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add LayoutObject pointer to each NGPhysicalFragment. This pointer is for: 1) Copying back data to the legacy layout tree inside NGBlockNode. 2) When the legacy layout tree is using fragments for geometry information this will be used while walking the fragment tree to access the layout object which generated the fragment. BUG=635619 Review-Url: https://codereview.chromium.org/2653773004 Cr-Commit-Position: refs/heads/master@{#445932} Committed: https://chromium.googlesource.com/chromium/src/+/f855b40902acc2b89ae360cac0eadd410bffd6a5

Patch Set 1 #

Patch Set 2 : fixup comments. #

Total comments: 6

Patch Set 3 : rebase. #

Patch Set 4 : address comments #

Patch Set 5 : rebase. #

Total comments: 4

Patch Set 6 : address comments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -84 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 3 4 5 8 chunks +5 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 1 2 3 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 2 3 4 5 6 chunks +51 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 2 3 4 5 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.h View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h View 1 2 5 chunks +9 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 36 (24 generated)
ikilpatrick
The other option for GetLayoutObject on NGPhysicalFragment was GeneratingLayoutObject()? ::shruggie::
3 years, 11 months ago (2017-01-24 00:11:30 UTC) #4
atotic
https://codereview.chromium.org/2653773004/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (left): https://codereview.chromium.org/2653773004/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#oldcode319 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:319: for (auto& node : positioned_out_of_flow_children) Where did this code ...
3 years, 11 months ago (2017-01-24 01:03:56 UTC) #7
ikilpatrick
+gleb as well now that i've touch floats as well :) https://codereview.chromium.org/2653773004/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (left): ...
3 years, 11 months ago (2017-01-24 04:44:48 UTC) #15
atotic
lgtm
3 years, 10 months ago (2017-01-24 19:54:10 UTC) #22
Gleb Lanbin
lgtm with nits https://codereview.chromium.org/2653773004/diff/80001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc (right): https://codereview.chromium.org/2653773004/diff/80001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc#newcode53 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:53: NGBlockLayoutAlgorithm algorithm(nullptr, style_.get(), first_child, space); /* ...
3 years, 10 months ago (2017-01-24 20:00:19 UTC) #23
ikilpatrick
https://codereview.chromium.org/2653773004/diff/80001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc (right): https://codereview.chromium.org/2653773004/diff/80001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc#newcode53 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:53: NGBlockLayoutAlgorithm algorithm(nullptr, style_.get(), first_child, space); On 2017/01/24 20:00:19, Gleb ...
3 years, 10 months ago (2017-01-24 23:34:50 UTC) #24
eae
LGTM https://codereview.chromium.org/2653773004/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h File third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h (right): https://codereview.chromium.org/2653773004/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h#newcode26 third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h:26: // Once we have transitioned fully to LayoutNG ...
3 years, 10 months ago (2017-01-25 00:00:42 UTC) #25
ikilpatrick
https://codereview.chromium.org/2653773004/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h File third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h (right): https://codereview.chromium.org/2653773004/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h#newcode26 third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h:26: // Once we have transitioned fully to LayoutNG it ...
3 years, 10 months ago (2017-01-25 00:05:39 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653773004/100001
3 years, 10 months ago (2017-01-25 00:06:27 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/375370)
3 years, 10 months ago (2017-01-25 02:06:44 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653773004/100001
3 years, 10 months ago (2017-01-25 02:38:50 UTC) #33
commit-bot: I haz the power
3 years, 10 months ago (2017-01-25 03:44:25 UTC) #36
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f855b40902acc2b89ae360cac0ea...

Powered by Google App Engine
This is Rietveld 408576698