Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2732)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java

Issue 2653753009: Remove refine icon from multi-PW suggestions (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
index c7d828dccbfad21554595f2f10832f6197d00207..c52533387512be01568d8efcb0a338fe65009fa2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
@@ -329,7 +329,8 @@ class SuggestionView extends ViewGroup {
mContentsView.mTextLine2.setVisibility(INVISIBLE);
}
setSuggestedQuery(suggestionItem, true, urlShown, urlHighlighted);
- setRefinable(!sameAsTyped);
+ setRefinable(!sameAsTyped
+ && suggestionType != OmniboxSuggestionType.PHYSICAL_WEB_OVERFLOW);
mmocny 2017/01/26 20:50:58 Nit: would it make sense to add this extra clause
cco3 2017/01/26 20:53:47 not really...then sameAsTyped wouldn't mean the su
} else {
@SuggestionIcon int suggestionIcon = SUGGESTION_ICON_MAGNIFIER;
if (suggestionType == OmniboxSuggestionType.VOICE_SUGGEST) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698