Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: test/mjsunit/unary-minus-deopt.js

Issue 2653753007: [tests] Cleanup tests that use assertOptimized()/assertUnoptimized(). (Closed)
Patch Set: Addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/smi-mul-const.js ('k') | tools/presubmit.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax 28 // Flags: --allow-natives-syntax --crankshaft --no-always-opt
29 29
30 // This is a boiled-down example happening in the Epic Citadel demo: 30 // This is a boiled-down example happening in the Epic Citadel demo:
31 // After deopting, the multiplication for unary minus stayed in Smi 31 // After deopting, the multiplication for unary minus stayed in Smi
32 // mode instead of going to double mode, leading to deopt loops. 32 // mode instead of going to double mode, leading to deopt loops.
33 33
34 function unaryMinusTest(x) { 34 function unaryMinusTest(x) {
35 var g = (1 << x) | 0; 35 var g = (1 << x) | 0;
36 // Optimized code will contain a LMulI with -1 as right operand. 36 // Optimized code will contain a LMulI with -1 as right operand.
37 return (g & -g) - 1 | 0; 37 return (g & -g) - 1 | 0;
38 } 38 }
39 39
40 unaryMinusTest(3); 40 unaryMinusTest(3);
41 unaryMinusTest(3); 41 unaryMinusTest(3);
42 %OptimizeFunctionOnNextCall(unaryMinusTest); 42 %OptimizeFunctionOnNextCall(unaryMinusTest);
43 unaryMinusTest(3); 43 unaryMinusTest(3);
44 assertOptimized(unaryMinusTest); 44 assertOptimized(unaryMinusTest);
45 45
46 // Deopt on kMinInt 46 // Deopt on kMinInt
47 unaryMinusTest(31); 47 unaryMinusTest(31);
48 // The following is normally true, but not with --stress-opt. :-/ 48 // The following is normally true, but not with --stress-opt. :-/
49 // assertUnoptimized(unaryMinusTest); 49 // assertUnoptimized(unaryMinusTest);
50 50
51 // We should have learned something from the deopt. 51 // We should have learned something from the deopt.
52 unaryMinusTest(31); 52 unaryMinusTest(31);
53 %OptimizeFunctionOnNextCall(unaryMinusTest); 53 %OptimizeFunctionOnNextCall(unaryMinusTest);
54 unaryMinusTest(31); 54 unaryMinusTest(31);
55 assertOptimized(unaryMinusTest); 55 assertOptimized(unaryMinusTest);
OLDNEW
« no previous file with comments | « test/mjsunit/smi-mul-const.js ('k') | tools/presubmit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698