Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: test/mjsunit/array-push5.js

Issue 2653753007: [tests] Cleanup tests that use assertOptimized()/assertUnoptimized(). (Closed)
Patch Set: Addressing comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/array-literal-transitions.js ('k') | test/mjsunit/array-shift4.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --allow-natives-syntax 5 // Flags: --allow-natives-syntax --crankshaft --no-always-opt
6 6
7 var v = 0; 7 var v = 0;
8 8
9 // Test that elements setters/getters on prototype chain set after the fact are 9 // Test that elements setters/getters on prototype chain set after the fact are
10 // property detected and don't lead to overzealous optimization. 10 // property detected and don't lead to overzealous optimization.
11 var my_array_proto = {}; 11 var my_array_proto = {};
12 my_array_proto.__proto__ = [].__proto__; 12 my_array_proto.__proto__ = [].__proto__;
13 13
14 function push_wrapper_2(array, value) { 14 function push_wrapper_2(array, value) {
15 array.push(value); 15 array.push(value);
(...skipping 17 matching lines...) Expand all
33 // Defining accessor should deopt optimized push. 33 // Defining accessor should deopt optimized push.
34 Object.defineProperty(my_array_proto, "3", { 34 Object.defineProperty(my_array_proto, "3", {
35 get: function() { return "get " + v; }, 35 get: function() { return "get " + v; },
36 set: function(value) { v += value; } 36 set: function(value) { v += value; }
37 }); 37 });
38 assertUnoptimized(push_wrapper_2); 38 assertUnoptimized(push_wrapper_2);
39 push_wrapper_2(array, 99); 39 push_wrapper_2(array, 99);
40 assertEquals(4, array.length); 40 assertEquals(4, array.length);
41 assertEquals(99, v); 41 assertEquals(99, v);
42 assertEquals("get 99", array[3]); 42 assertEquals("get 99", array[3]);
OLDNEW
« no previous file with comments | « test/mjsunit/array-literal-transitions.js ('k') | test/mjsunit/array-shift4.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698