Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2653753006: Fix MockSdk.fromFileUri() implementations. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix MockSdk.fromFileUri() implementations. This should fix the test failure on Windows bot. TBR R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f1f5d490d718d0d1b70bcfc7e56acfe1bbba331a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +12 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-25 20:08:01 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as f1f5d490d718d0d1b70bcfc7e56acfe1bbba331a (presubmit successful).
3 years, 11 months ago (2017-01-25 20:08:32 UTC) #3
Brian Wilkerson
3 years, 11 months ago (2017-01-25 20:12:37 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698