Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h

Issue 2653733005: Added parseShorthand method from the parser to CSSPropertyAPI.h. (Closed)
Patch Set: Moved implementation check into macro in CSSPropertyDescriptor.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h
diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h b/third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h
index d5cb6bd8fe52768b16808dd36ce71ff57c25054e..55c506ece5180104610878a8dd411bf5ec326905 100644
--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h
+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h
@@ -10,17 +10,14 @@ class CSSValue;
class CSSParserTokenRange;
class CSSParserContext;
+#define FUNCTION_IMPLEMENTED_FOR_PROPERTY(function, descriptor) \
+ descriptor.function != CSSPropertyAPI::function
+
// Stores function pointers matching those declared in CSSPropertyAPI.
struct CSSPropertyDescriptor {
const CSSValue* (*parseSingleValue)(CSSParserTokenRange&,
const CSSParserContext*);
-
- // Stores whether or not this descriptor is for a valid property. Do not
- // access the contents of this descriptor unless this value is true.
- // TODO(aazzam): Remove this once the switch in
- // CSSPropertyParser::parseSingleValue() has been completely replaced by
- // CSSPropertyDescriptors.
- bool temporaryCanReadValue;
+ bool (*parseShorthand)(bool, CSSParserTokenRange&, const CSSParserContext*);
// Returns the corresponding CSSPropertyDescriptor for a given CSSPropertyID.
// Use this function to access the API for a property. Returns a descriptor

Powered by Google App Engine
This is Rietveld 408576698