Add a UniqueVector class to GN

tools/gn/ninja_binary_target_writer_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/gn/ninja_binary_target_writer.h"
 #include "tools/gn/test_with_scope.h"
 
@@ skipping 11 matching lines @@
   target.sources().push_back(SourceFile("//foo/input3.o"));
   target.sources().push_back(SourceFile("//foo/input4.obj"));
   target.OnResolved();
 
   // Source set itself.
   {
     std::ostringstream out;
     NinjaBinaryTargetWriter writer(&target, setup.toolchain(), out);
     writer.Run();
 
-    // TODO(brettw) I think we'll need to worry about backslashes here
-    // depending if we're on actual Windows or Linux pretending to be Windows.
     const char expected_win[] =
         "defines =\n"
         "includes =\n"
         "cflags =\n"
         "cflags_c =\n"
         "cflags_cc =\n"
         "cflags_objc =\n"
         "cflags_objcc =\n"
         "target_name = bar\n"
         "target_out_dir = obj/foo\n"
@@ skipping 15 matching lines @@
   Target shlib_target(setup.settings(), Label(SourceDir("//foo/"), "shlib"));
   shlib_target.set_output_type(Target::SHARED_LIBRARY);
   shlib_target.deps().push_back(LabelTargetPair(&target));
   shlib_target.OnResolved();
 
   {
     std::ostringstream out;
     NinjaBinaryTargetWriter writer(&shlib_target, setup.toolchain(), out);
     writer.Run();
 
-    // TODO(brettw) I think we'll need to worry about backslashes here
-    // depending if we're on actual Windows or Linux pretending to be Windows.
     const char expected_win[] =
         "defines =\n"
         "includes =\n"
         "cflags =\n"
         "cflags_c =\n"
         "cflags_cc =\n"
         "cflags_objc =\n"
         "cflags_objcc =\n"
         "target_name = shlib\n"
         "target_out_dir = obj/foo\n"
         "root_out_dir = \n"
         "\n"
         "\n"
         "manifests = obj/foo/shlib.intermediate.manifest\n"
         "ldflags = /MANIFEST /ManifestFile:obj/foo/shlib.intermediate."
             "manifest\n"
         "libs =\n"
-        // Ordering of the obj files here is arbitrary. Currently they're put
-        // in a set and come out sorted.
-        "build shlib.dll shlib.dll.lib: solink ../../foo/input3.o "
-            "../../foo/input4.obj obj/foo/bar.input1.obj "
-            "obj/foo/bar.input2.obj\n"
+        // Ordering of the obj files here should come out in the order
+        // specified, with the target's first, followed by the source set's, in
+        // order.
+        "build shlib.dll shlib.dll.lib: solink obj/foo/bar.input1.obj "
+            "obj/foo/bar.input2.obj ../../foo/input3.o "
+            "../../foo/input4.obj\n"
         "  soname = shlib.dll\n"
         "  lib = shlib.dll\n"
         "  dll = shlib.dll\n"
         "  implibflag = /IMPLIB:shlib.dll.lib\n\n";
     std::string out_str = out.str();
 #if defined(OS_WIN)
     std::replace(out_str.begin(), out_str.end(), '\\', '/');
 #endif
     EXPECT_EQ(expected_win, out_str);
   }
 
   // A static library that depends on the source set (should not link it).
   Target stlib_target(setup.settings(), Label(SourceDir("//foo/"), "stlib"));
   stlib_target.set_output_type(Target::STATIC_LIBRARY);
   stlib_target.deps().push_back(LabelTargetPair(&target));
   stlib_target.OnResolved();
 
   {
     std::ostringstream out;
     NinjaBinaryTargetWriter writer(&stlib_target, setup.toolchain(), out);
     writer.Run();
 
-    // TODO(brettw) I think we'll need to worry about backslashes here
-    // depending if we're on actual Windows or Linux pretending to be Windows.
     const char expected_win[] =
         "defines =\n"
         "includes =\n"
         "cflags =\n"
         "cflags_c =\n"
         "cflags_cc =\n"
         "cflags_objc =\n"
         "cflags_objcc =\n"
         "target_name = stlib\n"
         "target_out_dir = obj/foo\n"
@@ skipping 24 matching lines @@
   target.set_output_type(Target::SHARED_LIBRARY);
   target.set_output_extension(std::string("so.6"));
   target.sources().push_back(SourceFile("//foo/input1.cc"));
   target.sources().push_back(SourceFile("//foo/input2.cc"));
   target.OnResolved();
 
   std::ostringstream out;
   NinjaBinaryTargetWriter writer(&target, setup.toolchain(), out);
   writer.Run();
 
-  // TODO(brettw) I think we'll need to worry about backslashes here
-  // depending if we're on actual Windows or Linux pretending to be Windows.
   const char expected[] =
       "defines =\n"
       "includes =\n"
       "cflags =\n"
       "cflags_c =\n"
       "cflags_cc =\n"
       "cflags_objc =\n"
       "cflags_objcc =\n"
       "target_name = shlib\n"
       "target_out_dir = obj/foo\n"
@@ skipping 27 matching lines @@
   Target target(setup.settings(), Label(SourceDir("//foo/"), "shlib"));
   target.set_output_type(Target::SHARED_LIBRARY);
   target.set_output_extension(std::string());
   target.sources().push_back(SourceFile("//foo/input1.cc"));
   target.sources().push_back(SourceFile("//foo/input2.cc"));
 
   std::ostringstream out;
   NinjaBinaryTargetWriter writer(&target, setup.toolchain(), out);
   writer.Run();
 
-  // TODO(brettw) I think we'll need to worry about backslashes here
-  // depending if we're on actual Windows or Linux pretending to be Windows.
   const char expected[] =
       "defines =\n"
       "includes =\n"
       "cflags =\n"
       "cflags_c =\n"
       "cflags_cc =\n"
       "cflags_objc =\n"
       "cflags_objcc =\n"
       "target_name = shlib\n"
       "target_out_dir = obj/foo\n"
       "root_out_dir = \n"
       "\n"
       "build obj/foo/shlib.input1.o: cxx ../../foo/input1.cc\n"
       "build obj/foo/shlib.input2.o: cxx ../../foo/input2.cc\n"
       "\n"
       "ldflags =\n"
       "libs =\n"
       "build libshlib.so: solink obj/foo/shlib.input1.o "
           "obj/foo/shlib.input2.o\n"
       "  soname = libshlib.so\n"
       "  lib = libshlib.so\n"
       "\n";
 
   std::string out_str = out.str();
 #if defined(OS_WIN)
   std::replace(out_str.begin(), out_str.end(), '\\', '/');
 #endif
   EXPECT_EQ(expected, out_str);
 }