Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3106)

Unified Diff: ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h

Issue 2653693004: UKM Sync Observer (Closed)
Patch Set: Split Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h
diff --git a/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h b/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h
index 365e8be9fa1a41405202d907e54c950e6f4ebd7f..c5555783ee051a5a380bcc4711d361df0619dc47 100644
--- a/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h
+++ b/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h
@@ -19,6 +19,7 @@
#include "components/metrics/profiler/tracking_synchronizer_observer.h"
#include "components/omnibox/browser/omnibox_event_global_tracker.h"
#include "components/ukm/observers/history_delete_observer.h"
+#include "components/ukm/observers/sync_disable_observer.h"
#include "ios/web/public/web_state/global_web_state_observer.h"
class IOSChromeStabilityMetricsProvider;
@@ -45,6 +46,7 @@ class IOSChromeMetricsServiceClient
: public metrics::MetricsServiceClient,
public metrics::TrackingSynchronizerObserver,
public ukm::HistoryDeleteObserver,
+ public ukm::SyncDisableObserver,
public web::GlobalWebStateObserver {
public:
~IOSChromeMetricsServiceClient() override;
@@ -79,6 +81,9 @@ class IOSChromeMetricsServiceClient
// ukm::HistoryDeleteObserver
void OnHistoryDeleted() override;
+ // ukm::SyncDisableObserver
Alexei Svitkine (slow) 2017/02/01 19:31:07 Nit: Add : Also on line 81.
Steven Holte 2017/02/03 00:04:34 Done.
+ void OnSyncPrefsChanged(bool must_purge) override;
+
// web::GlobalWebStateObserver:
void WebStateDidStartLoading(web::WebState* web_state) override;
void WebStateDidStopLoading(web::WebState* web_state) override;
@@ -118,8 +123,8 @@ class IOSChromeMetricsServiceClient
// there was recent activity.
void RegisterForNotifications();
- // Register to observe history delete events on a browser state.
- void RegisterForHistoryDeletions(ios::ChromeBrowserState* browser_state);
+ // Register to observe events on a browser state's services.
+ void RegisterForBrowserStateEvents(ios::ChromeBrowserState* browser_state);
// Called when a tab is parented.
void OnTabParented(web::WebState* web_state);

Powered by Google App Engine
This is Rietveld 408576698