Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.h

Issue 2653693004: UKM Sync Observer (Closed)
Patch Set: Split Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.h
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.h b/chrome/browser/metrics/chrome_metrics_service_client.h
index bf7e3b6fe8c443ed77427e722ade8d98e34c970b..f0e31800efe164b7f590fb6e58467549cdeaadf3 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.h
+++ b/chrome/browser/metrics/chrome_metrics_service_client.h
@@ -23,6 +23,7 @@
#include "components/metrics/proto/system_profile.pb.h"
#include "components/omnibox/browser/omnibox_event_global_tracker.h"
#include "components/ukm/observers/history_delete_observer.h"
+#include "components/ukm/observers/sync_disable_observer.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "ppapi/features/features.h"
@@ -50,7 +51,8 @@ class ProfilerMetricsProvider;
class ChromeMetricsServiceClient : public metrics::MetricsServiceClient,
public metrics::TrackingSynchronizerObserver,
public content::NotificationObserver,
- public ukm::HistoryDeleteObserver {
+ public ukm::HistoryDeleteObserver,
+ public ukm::SyncDisableObserver {
public:
~ChromeMetricsServiceClient() override;
@@ -89,6 +91,9 @@ class ChromeMetricsServiceClient : public metrics::MetricsServiceClient,
// ukm::HistoryDeleteObserver
void OnHistoryDeleted() override;
+ // ukm::SyncDisableObserver
Alexei Svitkine (slow) 2017/02/01 19:31:07 Nit: add : at the end. Same on line 91.
Steven Holte 2017/02/03 00:04:34 Done.
+ void OnSyncPrefsChanged(bool must_purge) override;
+
// Persistent browser metrics need to be persisted somewhere. This constant
// provides a known string to be used for both the allocator's internal name
// and for a file on disk (relative to chrome::DIR_USER_DATA) to which they
@@ -135,8 +140,8 @@ class ChromeMetricsServiceClient : public metrics::MetricsServiceClient,
// there was recent activity.
void RegisterForNotifications();
- // Call to listen for history deletions by the selected profile.
- void RegisterForHistoryDeletions(Profile* profile);
+ // Call to listen for events on the selected profile's services.
+ void RegisterForProfileEvents(Profile* profile);
// content::NotificationObserver:
void Observe(int type,

Powered by Google App Engine
This is Rietveld 408576698