Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(81)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/ukm/DEPS
Issue
2653693004
:
UKM Sync Observer (Closed)
Patch Set: Split
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/metrics/chrome_metrics_service_client.h
chrome/browser/metrics/chrome_metrics_service_client.cc
components/metrics/metrics_service_client.h
components/metrics/metrics_service_client.cc
components/metrics_services_manager/metrics_services_manager.cc
components/ukm/BUILD.gn
components/ukm/DEPS
components/ukm/observers/sync_disable_observer.h
components/ukm/observers/sync_disable_observer.cc
ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h
ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
View unified diff
|
Download patch
« components/metrics_services_manager/metrics_services_manager.cc
('K') |
« components/ukm/BUILD.gn
('k') |
components/ukm/observers/sync_disable_observer.h »
('j') |
components/ukm/observers/sync_disable_observer.h »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 "+components/metrics",
2 "+components/metrics",
3 "+components/prefs",
3 "+components/prefs",
4
"+components/sync",
4 "+components/variations",
5 "+components/variations",
5 ]
6 ]
OLD
NEW
« components/metrics_services_manager/metrics_services_manager.cc
('K') |
« components/ukm/BUILD.gn
('k') |
components/ukm/observers/sync_disable_observer.h »
('j') |
components/ukm/observers/sync_disable_observer.h »
('J')
Issue 2653693004: UKM Sync Observer (Closed)
Created 3 years, 10 months ago by Steven Holte
Modified 3 years, 9 months ago
Reviewers: Alexei Svitkine (slow), rkaplow, skym, Olivier, msramek
Base URL:
Comments: 61
This is Rietveld
408576698
Chromium Code Reviews
Issue 2653693004:
UKM Sync Observer (Closed)
