Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2653673011: Reenable parts of kernel/impact_test (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M tests/compiler/dart2js/dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 5 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-25 15:45:03 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-25 17:02:03 UTC) #3
Johnni Winther
3 years, 11 months ago (2017-01-26 09:38:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b699aba744bf857d0187c7a5afc8e9c702e4d9db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698