third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2653673006: Move loadType() to DocumentLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2653673006: Move loadType() to DocumentLoader (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 348534142fc7bc10275475e52a6c227239b250be..f20abcf564e0fe33dc3d7ba9d89260e36cdd8d40 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1631,7 +1631,7 @@ LocalFrame* WebLocalFrameImpl::createChildFrame(

// If we're moving in the back/forward list, we might want to replace the

// content of this child frame with whatever was there at that point.

HistoryItem* childItem = nullptr;

- if (isBackForwardLoadType(frame()->loader().loadType()) &&

+ if (isBackForwardLoadType(frame()->loader().documentLoader()->loadType()) &&

!frame()->document()->loadEventFinished())

childItem = webframeChild->client()->historyItemForNewChildFrame();