Move loadType() to DocumentLoader

third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
index 01b2c840b68d0d8a7829104fd1e101a3efa0d882..c2c8a3e8c5afdab0cee0678f857ac12a3cdfd618 100644
--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
@@ -529,7 +529,8 @@ NavigationPolicy FrameLoaderClientImpl::decidePolicyForNavigation(
       isBackForwardLoadType(toWebLocalFrameImpl(m_webFrame->parent())
                                 ->frame()
                                 ->loader()
-                                .loadType()) &&
+                                .documentLoader()

[yhirano, 2017/01/25 06:30:43]

This function can be called from DocumentLoader::redirectReceived, which means
previous FrameLoader::loadType() equals to
provisionalDocumentLoader()->loadType(), right?

This function can be called from FrameLoader::startLoad. In such a case
consulting documentLoader() looks fine (if it exists - see my question in
FrameLoader::checkCompleted). 

[Nate Chapin, 2017/01/25 17:25:29]

This logic is not looking at this frame's load type, but the parent's load type.

For this frame, the provisionalDocumentLoader()->loadType() would be correct.
But when checking the parent, the committed documentLoader() is always right. If
an iframe's navigation needs to check its parent's state, it always wants the
DocumentLoader of it's parent's current Document, which is the committed
DocumentLoader.

Did that make sense?

+                                ->loadType()) &&
       !toWebLocalFrameImpl(m_webFrame->parent())
            ->frame()
            ->document()