Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

Issue 2653643002: Move has_incoming_immediate_work to the TaskQueueManager (Closed)
Patch Set: Don't try to be quite so clever in TaskQueueManager::ComputeDelayTillNextTask Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/time_domain.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/scheduler/base/time_domain.h" 5 #include "platform/scheduler/base/time_domain.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/test/simple_test_tick_clock.h" 9 #include "base/test/simple_test_tick_clock.h"
10 #include "cc/test/ordered_simple_task_runner.h" 10 #include "cc/test/ordered_simple_task_runner.h"
(...skipping 15 matching lines...) Expand all
26 public: 26 public:
27 explicit MockTimeDomain(TimeDomain::Observer* observer) 27 explicit MockTimeDomain(TimeDomain::Observer* observer)
28 : TimeDomain(observer), 28 : TimeDomain(observer),
29 now_(base::TimeTicks() + base::TimeDelta::FromSeconds(1)) {} 29 now_(base::TimeTicks() + base::TimeDelta::FromSeconds(1)) {}
30 30
31 ~MockTimeDomain() override {} 31 ~MockTimeDomain() override {}
32 32
33 using TimeDomain::CancelDelayedWork; 33 using TimeDomain::CancelDelayedWork;
34 using TimeDomain::NextScheduledRunTime; 34 using TimeDomain::NextScheduledRunTime;
35 using TimeDomain::NextScheduledTaskQueue; 35 using TimeDomain::NextScheduledTaskQueue;
36 using TimeDomain::OnQueueHasIncomingImmediateWork; 36 using TimeDomain::OnQueueHasImmediateWork;
37 using TimeDomain::ScheduleDelayedWork; 37 using TimeDomain::ScheduleDelayedWork;
38 using TimeDomain::UnregisterQueue; 38 using TimeDomain::UnregisterQueue;
39 using TimeDomain::UpdateWorkQueues; 39 using TimeDomain::WakeupReadyDelayedQueues;
40 40
41 // TimeSource implementation: 41 // TimeSource implementation:
42 LazyNow CreateLazyNow() const override { return LazyNow(now_); } 42 LazyNow CreateLazyNow() const override { return LazyNow(now_); }
43 base::TimeTicks Now() const override { return now_; } 43 base::TimeTicks Now() const override { return now_; }
44 44
45 void AsValueIntoInternal( 45 void AsValueIntoInternal(
46 base::trace_event::TracedValue* state) const override {} 46 base::trace_event::TracedValue* state) const override {}
47 47
48 base::Optional<base::TimeDelta> DelayTillNextTask( 48 base::Optional<base::TimeDelta> DelayTillNextTask(
49 LazyNow* lazy_now) override { 49 LazyNow* lazy_now) override {
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 188
189 time_domain_->UnregisterQueue(task_queue_.get()); 189 time_domain_->UnregisterQueue(task_queue_.get());
190 task_queue_ = scoped_refptr<internal::TaskQueueImpl>(); 190 task_queue_ = scoped_refptr<internal::TaskQueueImpl>();
191 EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue)); 191 EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
192 EXPECT_EQ(task_queue2_.get(), next_task_queue); 192 EXPECT_EQ(task_queue2_.get(), next_task_queue);
193 193
194 time_domain_->UnregisterQueue(task_queue2_.get()); 194 time_domain_->UnregisterQueue(task_queue2_.get());
195 EXPECT_FALSE(time_domain_->NextScheduledTaskQueue(&next_task_queue)); 195 EXPECT_FALSE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
196 } 196 }
197 197
198 TEST_F(TimeDomainTest, UpdateWorkQueues) { 198 TEST_F(TimeDomainTest, WakeupReadyDelayedQueues) {
199 base::TimeDelta delay = base::TimeDelta::FromMilliseconds(50); 199 base::TimeDelta delay = base::TimeDelta::FromMilliseconds(50);
200 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay)); 200 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay));
201 base::TimeTicks now = time_domain_->Now(); 201 base::TimeTicks now = time_domain_->Now();
202 base::TimeTicks delayed_runtime = now + delay; 202 base::TimeTicks delayed_runtime = now + delay;
203 time_domain_->ScheduleDelayedWork(task_queue_.get(), delayed_runtime, now); 203 time_domain_->ScheduleDelayedWork(task_queue_.get(), delayed_runtime, now);
204 204
205 base::TimeTicks next_run_time; 205 base::TimeTicks next_run_time;
206 ASSERT_TRUE(time_domain_->NextScheduledRunTime(&next_run_time)); 206 ASSERT_TRUE(time_domain_->NextScheduledRunTime(&next_run_time));
207 EXPECT_EQ(delayed_runtime, next_run_time); 207 EXPECT_EQ(delayed_runtime, next_run_time);
208 208
209 LazyNow lazy_now = time_domain_->CreateLazyNow(); 209 LazyNow lazy_now = time_domain_->CreateLazyNow();
210 time_domain_->UpdateWorkQueues(&lazy_now); 210 time_domain_->WakeupReadyDelayedQueues(&lazy_now);
211 ASSERT_TRUE(time_domain_->NextScheduledRunTime(&next_run_time)); 211 ASSERT_TRUE(time_domain_->NextScheduledRunTime(&next_run_time));
212 EXPECT_EQ(delayed_runtime, next_run_time); 212 EXPECT_EQ(delayed_runtime, next_run_time);
213 213
214 time_domain_->SetNow(delayed_runtime); 214 time_domain_->SetNow(delayed_runtime);
215 lazy_now = time_domain_->CreateLazyNow(); 215 lazy_now = time_domain_->CreateLazyNow();
216 time_domain_->UpdateWorkQueues(&lazy_now); 216 time_domain_->WakeupReadyDelayedQueues(&lazy_now);
217 ASSERT_FALSE(time_domain_->NextScheduledRunTime(&next_run_time)); 217 ASSERT_FALSE(time_domain_->NextScheduledRunTime(&next_run_time));
218 } 218 }
219 219
220 TEST_F(TimeDomainTest, CancelDelayedWork) { 220 TEST_F(TimeDomainTest, CancelDelayedWork) {
221 base::TimeTicks now = time_domain_->Now(); 221 base::TimeTicks now = time_domain_->Now();
222 time_domain_->ScheduleDelayedWork( 222 time_domain_->ScheduleDelayedWork(
223 task_queue_.get(), now + base::TimeDelta::FromMilliseconds(20), now); 223 task_queue_.get(), now + base::TimeDelta::FromMilliseconds(20), now);
224 224
225 TaskQueue* next_task_queue; 225 TaskQueue* next_task_queue;
226 EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue)); 226 EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
(...skipping 18 matching lines...) Expand all
245 MockTimeDomain* CreateMockTimeDomain() override { 245 MockTimeDomain* CreateMockTimeDomain() override {
246 observer_.reset(new MockObserver()); 246 observer_.reset(new MockObserver());
247 return new MockTimeDomain(observer_.get()); 247 return new MockTimeDomain(observer_.get());
248 } 248 }
249 249
250 std::unique_ptr<MockObserver> observer_; 250 std::unique_ptr<MockObserver> observer_;
251 }; 251 };
252 252
253 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasImmediateWork) { 253 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasImmediateWork) {
254 EXPECT_CALL(*observer_, OnTimeDomainHasImmediateWork(task_queue_.get())); 254 EXPECT_CALL(*observer_, OnTimeDomainHasImmediateWork(task_queue_.get()));
255 time_domain_->OnQueueHasIncomingImmediateWork(task_queue_.get()); 255 time_domain_->OnQueueHasImmediateWork(task_queue_.get());
256 } 256 }
257 257
258 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasDelayedWork) { 258 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasDelayedWork) {
259 EXPECT_CALL(*observer_, OnTimeDomainHasDelayedWork(task_queue_.get())); 259 EXPECT_CALL(*observer_, OnTimeDomainHasDelayedWork(task_queue_.get()));
260 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _)); 260 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _));
261 base::TimeTicks now = time_domain_->Now(); 261 base::TimeTicks now = time_domain_->Now();
262 time_domain_->ScheduleDelayedWork( 262 time_domain_->ScheduleDelayedWork(
263 task_queue_.get(), now + base::TimeDelta::FromMilliseconds(10), now); 263 task_queue_.get(), now + base::TimeDelta::FromMilliseconds(10), now);
264 } 264 }
265 265
266 } // namespace scheduler 266 } // namespace scheduler
267 } // namespace blink 267 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/time_domain.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698