Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: chrome/browser/ui/task_manager/task_manager_table_model.cc

Issue 2653563003: Add a "Keepalive count" column to Task Manager. (Closed)
Patch Set: Address review comment re description Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/task_manager/task_manager_columns.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/task_manager/task_manager_table_model.cc
diff --git a/chrome/browser/ui/task_manager/task_manager_table_model.cc b/chrome/browser/ui/task_manager/task_manager_table_model.cc
index 086458e93cb4d5cb8e9485b311b6efb3bdbb4b19..306f1a40299c7612b3ac78374c766380f3eae0ae 100644
--- a/chrome/browser/ui/task_manager/task_manager_table_model.cc
+++ b/chrome/browser/ui/task_manager/task_manager_table_model.cc
@@ -234,6 +234,12 @@ class TaskManagerValuesStringifier {
return GetMemoryUsageText(stat.size, false);
}
+ base::string16 GetKeepaliveCountText(int keepalive_count) const {
+ if (keepalive_count < 0)
+ return n_a_string();
+ return base::IntToString16(keepalive_count);
+ }
+
const base::string16& n_a_string() const { return n_a_string_; }
const base::string16& zero_string() const { return zero_string_; }
const base::string16& backgrounded_string() const {
@@ -456,6 +462,11 @@ base::string16 TaskManagerTableModel::GetText(int row, int column) {
observed_task_manager()->GetMemoryState(tasks_[row]));
}
+ case IDS_TASK_MANAGER_KEEPALIVE_COUNT_COLUMN: {
+ return stringifier_->GetKeepaliveCountText(
+ observed_task_manager()->GetKeepaliveCount(tasks_[row]));
+ }
+
default:
NOTREACHED();
return base::string16();
@@ -778,6 +789,10 @@ void TaskManagerTableModel::UpdateRefreshTypes(int column_id, bool visibility) {
type = REFRESH_TYPE_MEMORY_STATE;
break;
+ case IDS_TASK_MANAGER_KEEPALIVE_COUNT_COLUMN:
+ type = REFRESH_TYPE_KEEPALIVE_COUNT;
+ break;
+
#if defined(OS_LINUX)
case IDS_TASK_MANAGER_OPEN_FD_COUNT_COLUMN:
type = REFRESH_TYPE_FD_COUNT;
« no previous file with comments | « chrome/browser/ui/task_manager/task_manager_columns.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698