Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2653553005: [Video] Fix DCHECK crash in PauseVideoIfHidden (Closed)
Patch Set: Added IsHidden() check Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 3ed41a3be186b1b824e04c158398018e35b974ea..0ab7b54d2cfdf4ee3dc09c257d782eea66e0c312 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -1405,11 +1405,15 @@ void WebMediaPlayerImpl::OnFrameHidden() {
if (watch_time_reporter_)
watch_time_reporter_->OnHidden();
- if (ShouldPauseVideoWhenHidden()) {
- PauseVideoIfNeeded();
- return;
- } else {
- DisableVideoTrackIfNeeded();
+ // OnFrameHidden() can be called when frame is closed, then IsHidden() will
+ // return false, so check explicitly.
+ if (IsHidden()) {
+ if (ShouldPauseVideoWhenHidden()) {
+ PauseVideoIfNeeded();
+ return;
+ } else {
+ DisableVideoTrackIfNeeded();
+ }
}
UpdatePlayState();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698