Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2653533002: Initialize memory for vulkan swapchain images.

Created:
3 years, 11 months ago by hyowon
Modified:
3 years, 11 months ago
Reviewers:
David Yen, piman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize memory for vulkan swapchain images. This fixes the failing BasicVulkanTests, EmptyVulkanSwaps and BasicRenderPass. vkQueuePresentKHR() or vkQueueSubmit() fails because the swapchain images were not initialized. The solution is to initially fill the swapchain images with 0 (black) in VulkanSwapChain::InitializeSwapImages(). BUG=683815 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M gpu/vulkan/vulkan_swap_chain.cc View 1 chunk +21 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
hyowon
Description was changed from ========== Initialize memory for vulkan swapchain images. This fixes the failing ...
3 years, 11 months ago (2017-01-23 06:38:18 UTC) #1
hyowon
Description was changed from ========== Initialize memory for vulkan swapchain images. This fixes the failing ...
3 years, 11 months ago (2017-01-23 06:52:30 UTC) #2
hyowon
3 years, 11 months ago (2017-01-23 06:52:30 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698