third_party/WebKit/Source/core/editing/DOMSelection.h - Issue 2653523003: Make DOMSelection cache Range

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/DOMSelection.h

Issue 2653523003: Make DOMSelection cache Range (Closed)

Patch Set: Clear cached Range considering Shadow Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007 Apple Inc. All rights reserved.	2 * Copyright (C) 2007 Apple Inc. All rights reserved.

3 * Copyright (C) 2012 Google Inc. All rights reserved.	3 * Copyright (C) 2012 Google Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 *	8 *

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 83 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
94 void addRange(Range*);	94 void addRange(Range*);

95 void deleteFromDocument();	95 void deleteFromDocument();

96 bool containsNode(const Node*, bool partlyContained) const;	96 bool containsNode(const Node*, bool partlyContained) const;

97 void selectAllChildren(Node*, ExceptionState&);	97 void selectAllChildren(Node*, ExceptionState&);

98	98

99 String toString();	99 String toString();

100	100

101 // Microsoft Selection Object API	101 // Microsoft Selection Object API

102 void empty();	102 void empty();

103	103

	104 void markRangeDirty();

	105

104 DECLARE_VIRTUAL_TRACE();	106 DECLARE_VIRTUAL_TRACE();

105	107

106 private:	108 private:

107 explicit DOMSelection(const TreeScope*);	109 explicit DOMSelection(const TreeScope*);

108	110

109 bool isAvailable() const;	111 bool isAvailable() const;

110	112

111 // Convenience method for accessors, does not check m_frame present.	113 // Convenience method for accessors, does not check m_frame present.

112 const VisibleSelection& visibleSelection() const;	114 const VisibleSelection& visibleSelection() const;

113	115

114 Node* shadowAdjustedNode(const Position&) const;	116 Node* shadowAdjustedNode(const Position&) const;

115 int shadowAdjustedOffset(const Position&) const;	117 int shadowAdjustedOffset(const Position&) const;

116	118

117 bool isValidForPosition(Node*) const;	119 bool isValidForPosition(Node*) const;

118	120

119 void addConsoleError(const String& message);	121 void addConsoleError(const String& message);

120	122

	123 Range* createRangeFromSelectionEditor();

	124

121 Member<const TreeScope> m_treeScope;	125 Member<const TreeScope> m_treeScope;

	126 Member<Range> m_Range;
	tkent 2017/01/25 07:59:12 m_Range -> m_range m_Range -> m_range yoichio 2017/01/27 08:33:04 Done. Show quoted text On 2017/01/25 07:59:12, tkent wrote: > m_Range -> m_range Done.
122 };	127 };

123	128

124 } // namespace blink	129 } // namespace blink

125	130

126 #endif // DOMSelection_h	131 #endif // DOMSelection_h

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/DOMSelection.cpp » ('j') | third_party/WebKit/Source/core/editing/DOMSelection.cpp » ('J')