Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2298)

Unified Diff: content/child/service_worker/service_worker_provider_context.cc

Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost (Closed)
Patch Set: Skip unittest for CrossSiteTransfer when PlzNavigate Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/service_worker/service_worker_provider_context.h ('k') | content/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_provider_context.cc
diff --git a/content/child/service_worker/service_worker_provider_context.cc b/content/child/service_worker/service_worker_provider_context.cc
index 9203346e432be89602563a830493b4000e7581bb..5b2020464755720f3ee2cfbe583d406051906612 100644
--- a/content/child/service_worker/service_worker_provider_context.cc
+++ b/content/child/service_worker/service_worker_provider_context.cc
@@ -46,9 +46,9 @@ class ServiceWorkerProviderContext::ControlleeDelegate
void AssociateRegistration(
std::unique_ptr<ServiceWorkerRegistrationHandleReference> registration,
- std::unique_ptr<ServiceWorkerHandleReference> installing,
- std::unique_ptr<ServiceWorkerHandleReference> waiting,
- std::unique_ptr<ServiceWorkerHandleReference> active) override {
+ std::unique_ptr<ServiceWorkerHandleReference> /* installing */,
+ std::unique_ptr<ServiceWorkerHandleReference> /* waiting */,
+ std::unique_ptr<ServiceWorkerHandleReference> /* active */) override {
DCHECK(!registration_);
registration_ = std::move(registration);
}
@@ -69,8 +69,8 @@ class ServiceWorkerProviderContext::ControlleeDelegate
bool HasAssociatedRegistration() override { return !!registration_; }
void GetAssociatedRegistration(
- ServiceWorkerRegistrationObjectInfo* info,
- ServiceWorkerVersionAttributes* attrs) override {
+ ServiceWorkerRegistrationObjectInfo* /* info */,
+ ServiceWorkerVersionAttributes* /* attrs */) override {
NOTREACHED();
}
@@ -111,7 +111,7 @@ class ServiceWorkerProviderContext::ControllerDelegate
}
void SetController(
- std::unique_ptr<ServiceWorkerHandleReference> controller) override {
+ std::unique_ptr<ServiceWorkerHandleReference> /* controller */) override {
NOTREACHED();
}
@@ -147,10 +147,12 @@ class ServiceWorkerProviderContext::ControllerDelegate
ServiceWorkerProviderContext::ServiceWorkerProviderContext(
int provider_id,
ServiceWorkerProviderType provider_type,
+ mojom::ServiceWorkerProviderAssociatedRequest request,
ThreadSafeSender* thread_safe_sender)
: provider_id_(provider_id),
main_thread_task_runner_(base::ThreadTaskRunnerHandle::Get()),
- thread_safe_sender_(thread_safe_sender) {
+ thread_safe_sender_(thread_safe_sender),
+ binding_(this, std::move(request)) {
if (provider_type == SERVICE_WORKER_PROVIDER_FOR_CONTROLLER)
delegate_.reset(new ControllerDelegate);
else
« no previous file with comments | « content/child/service_worker/service_worker_provider_context.h ('k') | content/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698