Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: content/browser/service_worker/service_worker_storage_unittest.cc

Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost (Closed)
Patch Set: Skip unittest for CrossSiteTransfer when PlzNavigate Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_storage_unittest.cc
diff --git a/content/browser/service_worker/service_worker_storage_unittest.cc b/content/browser/service_worker/service_worker_storage_unittest.cc
index 262ba79a1e26f38754462f91ce6fecb2fb3bf6ee..c74f8b9d71156ed3bf3698f1877e73e0bf4d89d7 100644
--- a/content/browser/service_worker/service_worker_storage_unittest.cc
+++ b/content/browser/service_worker/service_worker_storage_unittest.cc
@@ -1346,9 +1346,11 @@ TEST_F(ServiceWorkerResourceStorageTest, DeleteRegistration_ActiveVersion) {
registration_->SetActiveVersion(registration_->waiting_version());
storage()->UpdateToActiveState(
registration_.get(), base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
+ ServiceWorkerRemoteProviderEndpoint remote_endpoint;
std::unique_ptr<ServiceWorkerProviderHost> host = CreateProviderHostForWindow(
33 /* dummy render process id */, 1 /* dummy provider_id */,
- true /* is_parent_frame_secure */, context()->AsWeakPtr());
+ true /* is_parent_frame_secure */, context()->AsWeakPtr(),
+ &remote_endpoint);
registration_->active_version()->AddControllee(host.get());
bool was_called = false;
@@ -1396,9 +1398,11 @@ TEST_F(ServiceWorkerResourceStorageDiskTest, CleanupOnRestart) {
registration_->SetWaitingVersion(NULL);
storage()->UpdateToActiveState(
registration_.get(), base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
+ ServiceWorkerRemoteProviderEndpoint remote_endpoint;
std::unique_ptr<ServiceWorkerProviderHost> host = CreateProviderHostForWindow(
33 /* dummy render process id */, 1 /* dummy provider_id */,
- true /* is_parent_frame_secure */, context()->AsWeakPtr());
+ true /* is_parent_frame_secure */, context()->AsWeakPtr(),
+ &remote_endpoint);
registration_->active_version()->AddControllee(host.get());
bool was_called = false;
@@ -1554,9 +1558,11 @@ TEST_F(ServiceWorkerResourceStorageTest, UpdateRegistration) {
registration_->SetActiveVersion(registration_->waiting_version());
storage()->UpdateToActiveState(
registration_.get(), base::Bind(&ServiceWorkerUtils::NoOpStatusCallback));
+ ServiceWorkerRemoteProviderEndpoint remote_endpoint;
std::unique_ptr<ServiceWorkerProviderHost> host = CreateProviderHostForWindow(
33 /* dummy render process id */, 1 /* dummy provider_id */,
- true /* is_parent_frame_secure */, helper_->context()->AsWeakPtr());
+ true /* is_parent_frame_secure */, helper_->context()->AsWeakPtr(),
+ &remote_endpoint);
registration_->active_version()->AddControllee(host.get());
bool was_called = false;

Powered by Google App Engine
This is Rietveld 408576698