Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1988)

Unified Diff: content/common/service_worker/service_worker.mojom

Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/service_worker/service_worker.mojom
diff --git a/content/common/service_worker/service_worker.mojom b/content/common/service_worker/service_worker.mojom
index cadade0e8bc56d62b1f5ab18a0140839200d2d83..185e01856bf70cea7176437891115a86cd5d2a0f 100644
--- a/content/common/service_worker/service_worker.mojom
+++ b/content/common/service_worker/service_worker.mojom
@@ -6,12 +6,19 @@ module content.mojom;
import "content/common/service_worker/service_worker_provider.mojom";
-// Per-process browser-side interface bound to ServiceWorkerDispatcherHost.
-// Each InterfacePtrs on the same render process will be bound to the same
-// ServiceWorkerDispatcherHost.
+// Per-process browser-side interface bound to
+// content::ServiceWorkerDispatcherHost.
+// All InterfacePtrs on the same render process are bound to the same
+// content::ServiceWorkerDispatcherHost. The renderer uses this interface to
+// tell the browser when potential service worker clients are created and when
+// service workers are starting up.
falken 2017/05/30 04:12:32 I guess this violates our new policy of not mentio
shimazu 2017/05/30 07:24:35 Acknowledged.
shimazu 2017/06/01 08:18:54 Addressed this at https://chromium-review.googleso
interface ServiceWorkerDispatcherHost {
+ // Creates a content::ServiceWorkerProviderHost on the browser
+ // process. |provider_info| has Mojo endpoints to connect the provider host
+ // and the provider on the renderer together. The lifetime of
+ // ServiceWorkerProviderHost will be tied to the
+ // mojom::ServiceWorkerProviderHost interface.
OnProviderCreated(ServiceWorkerProviderHostInfo provider_info);
- OnProviderDestroyed(int32 provider_id);
// Informs the browser that a service worker is starting up. |provider_id|
// identifies the ServiceWorkerProviderHost hosting the service

Powered by Google App Engine
This is Rietveld 408576698