content/browser/service_worker/service_worker_context_request_handler_unittest.cc - Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler_unittest.cc

Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost (Closed)

Patch Set: Addressed comments from falken Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_context_unittest.cc » ('j') | content/browser/service_worker/service_worker_dispatcher_host_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

index 73e6040de521a4202ae32a850f14d3e4c52eb668..5f08d2307fe6daae715bd05b42e60ce40cd4b803 100644

--- a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

@@ -91,7 +91,8 @@ class ServiceWorkerContextRequestHandlerTest : public testing::Test {

std::unique_ptr<ServiceWorkerProviderHost> host =

CreateProviderHostForServiceWorkerContext(

helper_->mock_render_process_id(), 1 /* provider_id */,

- true /* is_parent_frame_secure */, context()->AsWeakPtr());

+ true /* is_parent_frame_secure */, context()->AsWeakPtr(),

+ &remote_endpoint_);

provider_host_ = host->AsWeakPtr();

context()->AddProviderHost(std::move(host));

provider_host_->running_hosted_version_ = version_;

@@ -136,6 +137,7 @@ class ServiceWorkerContextRequestHandlerTest : public testing::Test {

GURL scope_;

GURL script_url_;

GURL import_script_url_;

+ ServiceWorkerRemoteProviderEndpoint remote_endpoint_;

storage::BlobStorageContext blob_storage_context_;

};