Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2653493006: Issue 28386. Implement search for potential usages with the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -20 lines) Patch
M pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/search.dart View 2 chunks +73 lines, -0 lines 1 comment Download
M pkg/analyzer/test/src/dart/analysis/search_test.dart View 3 chunks +96 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-23 21:23:48 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2653493006/diff/1/pkg/analyzer/lib/src/dart/analysis/search.dart File pkg/analyzer/lib/src/dart/analysis/search.dart (right): https://codereview.chromium.org/2653493006/diff/1/pkg/analyzer/lib/src/dart/analysis/search.dart#newcode171 pkg/analyzer/lib/src/dart/analysis/search.dart:171: // await _addResultsInFile(results, element, relationToResultKind, file); Remove?
3 years, 11 months ago (2017-01-23 21:31:12 UTC) #2
scheglov
3 years, 11 months ago (2017-01-23 22:07:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a483610a96ff59cb3142f9cc64a69e896c854a5c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698