Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2653493004: Change @checked to covariant in strong tests (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change @checked to covariant in strong tests Per #28168 R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/863052c586762f7a7aac8459dae7f357912b0e9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M tests/language_strong/covariant_override/runtime_check_test.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M tests/language_strong/covariant_override/tear_off_type_test.dart View 4 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 11 months ago (2017-01-23 13:49:21 UTC) #3
Bob Nystrom
lgtm
3 years, 11 months ago (2017-01-23 17:14:49 UTC) #4
vsm
3 years, 11 months ago (2017-01-23 20:46:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
863052c586762f7a7aac8459dae7f357912b0e9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698